feat(table): add indexBy prop for ID-based expansion tracking#678
Open
platex-rehor-bot wants to merge 1 commit into
Open
feat(table): add indexBy prop for ID-based expansion tracking#678platex-rehor-bot wants to merge 1 commit into
platex-rehor-bot wants to merge 1 commit into
Conversation
RHCLOUD-48835 Support tracking expanded rows by a data property instead of array index. When indexBy is provided, expansion state follows the correct row through sort, filter, and pagination operations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
indexByprop toDataViewTableBasicandDataViewTableTreecomponents. When provided, expanded row state is tracked by a stable data property (e.g.,id) instead of the array index, so expansion follows the correct row through sorting, filtering, and pagination.Closes #677
RHCLOUD-48835
Changes
indexByprop. When set, expansion state (expandedRowsState,expandedColumnIndex) is keyed by the resolved row property instead ofrowIndex.ExpandableContent.rowIdtype widened tostring | number.indexByprop. When set,getNodeId()resolves node identity from the specified property instead of the defaultidfield.indexByprop passes through to both basic and tree variants via their existing prop interfaces.indexBypreserves current index-based behavior.Usage
Test plan
🤖 Generated with Claude Code