Support Elasticsearch 8 / FOSElasticaBundle 7 (PHP 8.1+)#41
Open
mussbach wants to merge 1 commit into
Open
Conversation
Bump dependency constraints to the ES8-compatible line (friendsofsymfony/elastica-bundle ^7.0, PHP ^8.1) and add the ': void' return type to QueuePagerPersister::insert() required by FOSElasticaBundle 7.x's PagerPersisterInterface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the dependency constraints to the Elasticsearch 8–compatible line and adapts the one signature the new interface requires:
friendsofsymfony/elastica-bundle:^6.0→^7.0(the ES8 /ruflin/elastica ^8line)php:^7.1|^8.0→^8.1QueuePagerPersister::insert()gains the: voidreturn type now declared by FOSElasticaBundle 7.x'sPagerPersisterInterface::insert(). Without it the class fatals on autoload under FOS 7.No behavioural change.
symfony/framework-bundlealready allowed^6.0|^7.0.