Skip to content

Treat the populate reply wait as an idle timeout so large indexes can finish #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mussbach wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Treat the populate reply wait as an idle timeout so large indexes can finish #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Persister/QueuePagerPersister.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,15 @@ public function insert(PagerInterface $pager, array $options = array())
} while ($page <= $lastPage);

$consumer = $this->context->createConsumer($replyQueue);
// Treat limit_overall_reply_time as an idle timeout rather than a hard overall cap: as long as
// replies keep arriving the consumers are making progress, so the deadline is pushed forward on
// each reply. This lets large indexes (whose population takes far longer than the timeout) finish
// while still aborting if the consumers go silent (e.g. all workers died).
$limitTime = microtime(true) + $options['limit_overall_reply_time'];
while ($sentCount) {
if ($message = $consumer->receive($options['reply_receive_timeout'])) {
$sentCount--;
$limitTime = microtime(true) + $options['limit_overall_reply_time'];

$data = JSON::decode($message->getBody());

Expand All @@ -139,10 +144,8 @@ public function insert(PagerInterface $pager, array $options = array())
$data['options']
);
$this->dispatcher->dispatch($event);
}

if (microtime(true) > $limitTime) {
throw new \LogicException(sprintf('Overall reply time (%s seconds) has been exceeded.', $options['limit_overall_reply_time']));
} elseif (microtime(true) > $limitTime) {
throw new \LogicException(sprintf('No populate reply received within %s seconds; the consumers appear to be stuck.', $options['limit_overall_reply_time']));
}
}

Expand Down