ci: fix lint failures blocking main#2496
Merged
Merged
Conversation
clang-format wants the empty while-loop body on its own line. zizmor's github-app audit (added in 1.26) flags create-github-app-token without explicit permission-* inputs; the release app only needs contents:write (commits, tags, refs, releases) and actions:write (gh workflow run dispatch of downstream builds).
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes deterministic lint failures currently breaking main by aligning C formatting with clang-format expectations and addressing zizmor’s new github-app audit requirement in the release workflow.
Changes:
- Adjusted an empty-body
whileloop infrankenphp.cto matchclang-format’s required layout. - Scoped the GitHub App installation token permissions in the release workflow to only
contents: writeandactions: write.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frankenphp.c | Reformats the kevent EINTR retry loop so clang-format --Werror passes. |
| .github/workflows/release.yaml | Restricts actions/create-github-app-token@v3 token permissions to satisfy zizmor github-app audit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dunglas
changed the title
Contributor
|
Not sure the autoscaling test is flaky. |
dunglas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red on the Lint Code Base job for two deterministic reasons.
clang-format
frankenphp.c:141— the emptywhilebody must sit on its own line.zizmor
github-appzizmor 1.26 added the
github-appaudit, which flagsactions/create-github-app-tokeninvocations that inherit blanket installation permissions. Scoped the release app token (dunglas-release) to what it actually uses:contents: write— commits, tags, refs, GitHub releasesactions: write—gh workflow rundispatch of downstream builds (static/docker/windows)Both verified locally:
zizmorreports no findings,clang-format --dry-run --Werroris clean.