Fix use-after-free in json_encode() of a JsonSerializable object#22470
Open
iliaal wants to merge 1 commit into
Open
Fix use-after-free in json_encode() of a JsonSerializable object#22470iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
php_json_encode_serializable_object() holds a raw pointer to the object and its recursion guard across the jsonSerialize() call. A user error handler invoked during that call can drop the object's last reference, leaving the post-call recursion-guard clear and the return-value identity check reading freed memory. Pin the object across the call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_json_encode_serializable_object() keeps the object pointer and its recursion guard live across the jsonSerialize() call. An error handler invoked during that call can drop the object's last reference through an aliased array element, leaving the post-call recursion-guard clear and the return-value identity check reading freed memory. Pin the object across the call. The 8.5 and master encoder dispatches through zend_call_known_function() and gets the same fix in php-src#22469.