Skip to content

ext/standard: Fix range() calculated size in HT_MAX_SIZE ValueError #22513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arshidkv12 wants to merge 2 commits into
base: PHP-8.4
Choose a base branch
from
+30 −2
Open

ext/standard: Fix range() calculated size in HT_MAX_SIZE ValueError #22513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bec8b8
ext/standard: Fix range() calculated size in HT_MAX_SIZE ValueError m…
arshidkv12 Jun 29, 2026
2e9316e
ext/standard: Fix range() calculated size in HT_MAX_SIZE ValueError m…
arshidkv12 Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/standard/array.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2872,9 +2872,9 @@ PHP_FUNCTION(array_fill_keys)

#define RANGE_CHECK_LONG_INIT_ARRAY(start, end, _step) do { \
zend_ulong __calc_size = ((zend_ulong) start - end) / (_step); \
if (__calc_size >= HT_MAX_SIZE - 1) { \
if (__calc_size > HT_MAX_SIZE - 1) { \
zend_value_error(\
"The supplied range exceeds the maximum array size: start=" ZEND_LONG_FMT " end=" ZEND_LONG_FMT " step=" ZEND_LONG_FMT, end, start, (_step)); \
"The supplied range exceeds the maximum array size: start=" ZEND_LONG_FMT " end=" ZEND_LONG_FMT " step=" ZEND_LONG_FMT, end, start, (_step)); \
RETURN_THROWS(); \
} \
size = (uint32_t)(__calc_size + 1); \
Expand Down
28 changes: 28 additions & 0 deletions ext/standard/tests/array/gh22505.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
--TEST--
GH-22505 : range() reports the correct calculated size when exceeding HT_MAX_SIZE
--INI--
memory_limit=20G

@devnexen devnexen Jun 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this test actually run on CI ??

@arshidkv12 arshidkv12 Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it is running. range(0, (1 << 30)) code needed minimum 17G.

--SKIPIF--
<?php
if (!getenv('RUN_RESOURCE_HEAVY_TESTS')) die('skip resource-heavy test');
if (getenv('SKIP_SLOW_TESTS')) die('skip slow test');
if (PHP_INT_SIZE != 8) die('skip 64-bit only');
?>
--FILE--
<?php
try {
$arr = range(0, (1 << 30) - 1);
unset($arr);
} catch (ValueError $e) {
echo $e->getMessage(), "\n";
}
try {
range(0, (1 << 30));
} catch (ValueError $e) {
echo $e->getMessage(), "\n";
}
echo 'Done';
?>
--EXPECT--
The supplied range exceeds the maximum array size: start=0 end=1073741824 step=1
Done
Loading