Skip to content

Navigation Menu

Appearance settings

- AI CODE CREATION
  GitHub CopilotWrite better code with AI
  GitHub Copilot appDirect agents from issue to merge
  MCP Registry^NewIntegrate external tools
- DEVELOPER WORKFLOWS
  ActionsAutomate any workflow
  CodespacesInstant dev environments
  IssuesPlan and track work
  Code ReviewManage code changes
- APPLICATION SECURITY
  GitHub Advanced SecurityFind and fix vulnerabilities
  Code securitySecure your code as you build
  Secret protectionStop leaks before they start
- EXPLORE
  Why GitHub
  Documentation
  Blog
  Changelog
  Marketplace
View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

Uh oh!

There was an error while loading. Please reload this page.

phpstan / phpstan-src Public

Notifications You must be signed in to change notification settings
Fork 578
Star 394

Code
Pull requests 142
Actions
Security and quality
Insights

Additional navigation options

Code
Pull requests
Actions
Security and quality
Insights

Single-pass expression analysis groundwork - answer type questions from ExpressionResults#5857

Open

ondrejmirtes wants to merge 227 commits into

2.2.xphpstan/phpstan-src:2.2.xfrom

resolve-type-rewrite-2phpstan/phpstan-src:resolve-type-rewrite-2Copy head branch name to clipboard

Conversation Commits227 (227)Checks Files changed

Open

Single-pass expression analysis groundwork - answer type questions from ExpressionResults#5857
ondrejmirtes wants to merge 227 commits into
2.2.xfrom
resolve-type-rewrite-2

Commits

Commits on Jun 30, 2026

Introduce ExpressionResultFactory
ondrejmirtes
committed
ExpressionResult - add beforeScope
ondrejmirtes
committed
ExpressionResult - add Expr
ondrejmirtes
committed
Store ExpressionResult instead of before-Scope
ondrejmirtes
committed
Fill the missing gaps in expr processing
ondrejmirtes
committed
Divide ExprHandler into TypeResolvingExprHandler
ondrejmirtes
committed
ScalarHandler stops implementing TypeResolvingExprHandler
ondrejmirtes
committed
ExpressionResultStorageStack - answer type questions from ExpressionResults

ondrejmirtes
and
claude
committed
Migrate ArrayHandler - per-item types from ExpressionResults

ondrejmirtes
and
claude
committed
Throw on unbalanced ExpressionResultStorageStack pop

ondrejmirtes
and
claude
committed
Fix PHP 7.4 compat
ondrejmirtes
committed
Migrate VariableHandler and InstanceofHandler - narrowing from ExpressionResults

ondrejmirtes
and
claude
committed
Add regression tests for evaluation-point array item types

ondrejmirtes
and
claude
committed
Add regression test for certainty of undefined variables in loops

ondrejmirtes
and
claude
committed
Store expressions even without FNSR
ondrejmirtes
committed
Only sureNot specifications skip certainly-undefined variables

ondrejmirtes
and
claude
committed
This is better
ondrejmirtes
committed
ExpressionResult::createTypesCallback - the inside-out TypeSpecifier::create()

ondrejmirtes
and
claude
committed
Coalesce, Ternary, BooleanAnd, BooleanOr stop implementing TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
Add regression test for conditional holders narrowing coalesce of properties

ondrejmirtes
and
claude
committed
Never process expressions on a FiberScope

ondrejmirtes
and
claude
committed
Convert rule-facing FiberScope at the new-world hook boundary

ondrejmirtes
and
claude
committed
Guard that only synthetic nodes reach the pending-fiber on-demand path

ondrejmirtes
and
claude
committed
Fix immediately-invoked-closure fiber flush; make the new-world guard accurate

ondrejmirtes
and
claude
committed
Flush pending fibers only at scope boundaries; process dropped call args

ondrejmirtes
and
claude
committed
Add PHPSTAN_GUARD_NW guard: no getType on a real node before processExprNode

ondrejmirtes
and
claude
committed
BitwiseNotHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
One more should-not
ondrejmirtes
committed
UnaryMinusHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
UnaryPlusHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
ConstFetchHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
PrintHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
ThrowHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
ExitHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
EvalHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
IncludeHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
YieldFromHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
ClassConstFetchHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
InterpolatedStringHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
CloneHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
YieldHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
AlwaysRememberedExprHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
NativeTypeExprHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
FunctionCallableNodeHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
MethodCallableNodeHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
StaticMethodCallableNodeHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
InstantiationCallableNodeHandler is no longer TypeResolvingExprHandler

ondrejmirtes
and
claude
committed
TypeExprHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
Fix failure of forwarding ExpressionResult
ondrejmirtes
committed
ErrorSuppressHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
CastHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
CastStringHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
PostIncHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
PostDecHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
PipeHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
PreIncHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
PreDecHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
AssignOpHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
AssignHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
Track containsNullsafe on ExpressionResult and propagate it through fetch/call chains
ondrejmirtes
committed
PropertyFetchHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
StaticPropertyFetchHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
Store ArrayDimFetch assign-target results with a typeCallback
ondrejmirtes
committed
ArrayDimFetchHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
Introduce IssetabilityDescriptor and fold it in MutatingScope::issetCheck
ondrejmirtes
committed
Move issetCheck onto ExpressionResult with isset()/empty() convenience
ondrejmirtes
committed
CoalesceHandler reads issetCheck from the left result instead of the scope
ondrejmirtes
committed
EmptyHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
Match issetCheckUndefined ordering in IssetabilityDescriptor::checkUndefined
ondrejmirtes
committed
Re-evaluate getCurrentTypesOfSpecifiedExpr on the asking scope
ondrejmirtes
committed
Rules\IssetCheck folds IssetabilityDescriptor instead of re-walking the AST
ondrejmirtes
committed
MatchHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
NullsafePropertyFetchHandler and NullsafeMethodCallHandler are no longer TypeResolvingExprHandler
ondrejmirtes
committed
Move first-class callable type resolution into the *CallableNode handlers
ondrejmirtes
committed
Price synthetic narrowing expressions on demand in getCurrentTypesOfSpecifiedExpr
ondrejmirtes
committed
BinaryOpHandler and BooleanNotHandler are no longer TypeResolvingExprHandler
ondrejmirtes
committed
Fix getIssetabilityDescriptor shadowed by descriptor-less assignment-target placeholders
ondrejmirtes
committed
Eliminate the OriginalPropertyTypeExpr virtual node
ondrejmirtes
committed
Eliminate the GetOffsetValueTypeExpr virtual node
ondrejmirtes
committed
Eliminate the GetIterableKeyTypeExpr virtual node
ondrejmirtes
committed
Eliminate the GetIterableValueTypeExpr virtual node
ondrejmirtes
committed
ExistingArrayDimFetchHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
UnsetOffsetExprHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
SetOffsetValueTypeExprHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
SetExistingOffsetValueTypeExprHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
Read operand types from ExpressionResults in Throw/BooleanAnd/Coalesce handlers
ondrejmirtes
committed
Read operand types from ExpressionResults in Ternary/ArrayDimFetch/PropertyFetch handlers
ondrejmirtes
committed
Read sub-expression types from ExpressionResults in offset Virtual handlers
ondrejmirtes
committed
Read child/narrowed types from results instead of Scope::getType in leaf handlers
ondrejmirtes
committed
Process synthetic offsetGet/callable nodes in processExpr, read results in callbacks
ondrejmirtes
committed
Add readStoredOrPriceOnDemand/priceSyntheticOnDemand and use them instead of Scope::getType in property/nullsafe/boolean/assignop handlers
ondrejmirtes
committed
Price synthetic unary-minus operand on demand instead of Scope::getType
ondrejmirtes
committed
Read child/synthetic types via result or helpers in Match/BinaryOp/Equality instead of Scope::getType
ondrejmirtes
committed
Thread NodeScopeResolver into narrowing/throw-point helpers to avoid Scope::getType
ondrejmirtes
committed
Read child/synthetic types via results or helpers in AssignHandler's assign machinery
ondrejmirtes
committed
Read expr types via results or helpers in NodeScopeResolver instead of Scope::getType
ondrejmirtes
committed
Correct the explanation of the two load-bearing Scope::getType() exceptions
ondrejmirtes
committed
Read Identical operand types from results in RicherScopeGetTypeHelper when called inside-out
ondrejmirtes
committed
Read expr types from results in SpecifiedTypes::normalize when called inside-out
ondrejmirtes
committed
Read assign-target sub-expression types from their results instead of the on-demand helpers in AssignHandler
ondrejmirtes
committed
Read while-loop condition type from its result instead of the on-demand helper
ondrejmirtes
committed
Pass already-computed results into ImplicitToStringCallHelper and read operand types directly in BinaryOp/Match
ondrejmirtes
committed
NSRT test for precise Scope
ondrejmirtes
committed
Extract intrinsic argument parameter overrides from selectFromArgs into a pluggable applyIntrinsicArgOverrides
ondrejmirtes
committed
Resolve argument types on an arg-to-arg evolving scope and select the parameters acceptor via selectFromTypes in processArgs
ondrejmirtes
committed
FuncCallHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
MethodCallHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
NewHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
StaticCallHandler is no longer TypeResolvingExprHandler
ondrejmirtes
committed
Extract combineVariantsForNormalization into a shared ParametersAcceptorSelector helper
ondrejmirtes
committed
Add regression test for #13253
ondrejmirtes
committed
Add regression test for #14396
ondrejmirtes
committed
Call handleDefaultTruthyOrFalseyContext on $this->typeSpecifier in migrated handlers
ondrejmirtes
committed
Rework issetCheck with single-pass
ondrejmirtes
committed
Resolve isset() narrowing types from computed results, not Scope::getType
ondrejmirtes
committed
ClosureHandler and ArrowFunctionHandler are no longer TypeResolvingExprHandler
ondrejmirtes
committed
Build the closure and arrow function type from the single body walk
ondrejmirtes
committed
Enter closure and arrow function scopes without re-walking the body
ondrejmirtes
committed
Simplify ExpressionResult::getType methods now that TypeResolvingExprHandler is gone
ondrejmirtes
committed
Throw on unhandled expr
ondrejmirtes
committed
Resolve the IssetExpr virtual node through an ExprHandler
ondrejmirtes
committed
Do not ensure non-nullability of the isset/empty/?? operand itself
ondrejmirtes
committed
Decide the nullsafe short-circuit from the receiver's real type
ondrejmirtes
committed
Resolve the PossiblyImpureCallExpr virtual node through an ExprHandler
ondrejmirtes
committed
Resolve the backtick operator through an ExprHandler
ondrejmirtes
committed
Keep the narrowed type when applySpecifiedTypes changes isset certainty
ondrejmirtes
committed
Resolve a maybe-existing property to its declared type instead of ErrorType
ondrejmirtes
committed
Treat a property with a default value as always set in isset resolution
ondrejmirtes
committed
Revert "Simplify ExpressionResult::getType methods now that TypeResolvingExprHandler is gone"
ondrejmirtes
committed
Compose AlwaysRememberedExpr narrowing inside-out via createTypesCallback
ondrejmirtes
committed
Compose nullsafe narrowing inside-out via createTypesCallback
ondrejmirtes
committed
Compose method/static call narrowing inside-out via createTypesCallback
ondrejmirtes
committed
Compose function call narrowing inside-out via createTypesCallback
ondrejmirtes
committed
Gate the nullsafe createTypesCallback on containsNull
ondrejmirtes
committed
Compose equality operand narrowing inside-out via createSubjectTypes
ondrejmirtes
committed
Route all of EqualityTypeSpecifyingHelper's narrowing through createForSubject
ondrejmirtes
committed
Route BinaryOp / Isset / conditional-holder narrowing through createForSubject
ondrejmirtes
committed
Resolve child narrowing on demand instead of via specifyTypesInCondition
ondrejmirtes
committed
Resolve BinaryOpHandler re-dispatched conditions on demand
ondrejmirtes
committed
Resolve equality re-dispatched conditions on demand
ondrejmirtes
committed
Resolve empty()'s isset-or-falsey condition on demand
ondrejmirtes
committed
Compose negation narrowing from the operand result; isset on demand
ondrejmirtes
committed
Thread operand results into equality narrowing
ondrejmirtes
committed
Compose remembered-operand narrowing from the result, dropping manual unwraps
ondrejmirtes
committed
Drop the AlwaysRememberedExpr fan-out from TypeSpecifier::create
ondrejmirtes
committed
Resolve conditional-after-assign narrowing on demand
ondrejmirtes
committed
Resolve nullsafe receiver-and-fetch condition on demand
ondrejmirtes
committed
Read expression-statement narrowing from its result
ondrejmirtes
committed
Resolve the impossible-check condition through the scope's dispatcher
ondrejmirtes
committed
Apply the expression-statement narrowing via applySpecifiedTypes
ondrejmirtes
committed
Apply do-while exit narrowing from the condition result
ondrejmirtes
committed
Narrow control-flow scopes via applySpecifiedTypes, not filterBy*Value
ondrejmirtes
committed
Require typeCallback and specifyTypesCallback on ExpressionResult
ondrejmirtes
committed
Remove todo
ondrejmirtes
committed
Replace handleDefaultTruthyOrFalseyContext with specifyDefaultTypes
ondrejmirtes
committed
Read operand/receiver types from their results, not Scope::getType
ondrejmirtes
committed
Guard on-demand pricing paths with PHPSTAN_GUARD_NW

ondrejmirtes
and
claude
committed
Capture per-arg ExpressionResults; read appending-arg types from them
ondrejmirtes
committed
Read array_splice and resolveReturnType arg types from their results
ondrejmirtes
committed
Carry the ??= left side's isset descriptor into its coalesce type
ondrejmirtes
committed
Find the early-terminating expression after processing the statement
ondrejmirtes
committed
Consume the processed arg result for the callable-arg check in processArgs
ondrejmirtes
committed
Resolve the arrow function return type after its body is processed
ondrejmirtes
committed
Compute Closure::bind's bound scope from its processed arguments
ondrejmirtes
committed
Fix PHPStan self-analysis errors in NodeScopeResolver
ondrejmirtes
committed
Read impossible-check narrowing from the call's ExpressionResult
ondrejmirtes
committed
Gate the processArgs fast path on parameter late-resolvability only
ondrejmirtes
committed
Don't route curl_setopt(_array) through the metadata pre-pass
ondrejmirtes
committed
Don't route implode/join through the metadata pre-pass
ondrejmirtes
committed
Supply array_map's callback parameter type via a closure-type extension
ondrejmirtes
committed
Supply array_filter/walk/find callback parameter types via closure-type extensions
ondrejmirtes
committed
Read array_walk's original array type after its argument is processed
ondrejmirtes
committed
Make Closure::bind/bindTo single-pass; drop the empty argsHaveIntrinsicArgOverride gate
ondrejmirtes
committed
Resolve single-variant generic acceptors incrementally so they are single-pass
ondrejmirtes
committed
Select multi-variant acceptors by argument count so processArgs is single-pass
ondrejmirtes
committed
Deduplicate constant-condition vs impossible-check reports via collectors instead of asking the type specifier inline
ondrejmirtes
committed
Process a dynamic function-call name before reading its type
ondrejmirtes
committed
Process a nested array-dimension before reading its type in AssignHandler
ondrejmirtes
committed
Process an assign-op Variable/property target as a read before composing its type
ondrejmirtes
committed
Process Closure::call's new-$this argument before reading its type
ondrejmirtes
committed
Process clone()'s arguments before reading them in clone-with handling
ondrejmirtes
committed
Evaluate an array-dim assignment's value before reading its type
ondrejmirtes
committed
Read the foreach value variable's narrowed type by name in the loop array rewrite
ondrejmirtes
committed
Carry the nullsafe receiver type to its rule via a virtual node
ondrejmirtes
committed
Drop the dead Expr parameter from ExpressionResult's typeCallback
ondrejmirtes
committed
Build pre-inc/dec literal types via ConstantTypeHelper, not the scope
ondrejmirtes
committed
Resolve lexical context once at create()-time in three type callbacks
ondrejmirtes
committed
Resolve the instanceof Name class type once at create()-time
ondrejmirtes
committed
Reprocess the switch subject for the exhaustiveness check instead of re-running its result on a foreign scope
ondrejmirtes
committed
Reprocess the foreach iteratee and while condition on their narrowed scopes
ondrejmirtes
committed
Reprocess coalesce/ternary/match subjects on their narrowed scopes in the type callbacks
ondrejmirtes
committed
Reprocess the foreach iteratee on the post-loop scope for value/key-type detection
ondrejmirtes
committed
Narrow the pinned-name property fetch via applySpecifiedTypes, not filterByTruthyValue
ondrejmirtes
committed
Make specifyTypesCallback required and getSpecifiedTypesForScope non-nullable
ondrejmirtes
committed
Narrow synthetic conditions via processExprOnDemand, not filterByTruthyValue, in leaf handlers
ondrejmirtes
committed
Read wrapped operand types via getType/getNativeType in cast/clone/unary/suppress callbacks
ondrejmirtes
committed
Read child types via getType/getNativeType in post/pre-inc/dec, pipe, yield-from, interpolated-string callbacks
ondrejmirtes
committed
Read the ternary condition type via getType/getNativeType in the type callback
ondrejmirtes
committed
Propagate the assigned value into byref-intertwined variables instead of re-reading the slot
ondrejmirtes
committed
Read binary-op operands via getType/getNativeType in the type callback
ondrejmirtes
committed
Read the left operand boolean via getType/getNativeType in boolean type callbacks
ondrejmirtes
committed
Resolve property fetch types without the asking scope
ondrejmirtes
committed
Resolve static property fetch types without the asking scope
ondrejmirtes
committed
Resolve method call return types without the asking scope
ondrejmirtes
committed
Resolve static call return types without the asking scope
ondrejmirtes
committed
Resolve function call return types without the asking scope
ondrejmirtes
committed
Resolve nullsafe fetch/call short-circuit types without the asking scope
ondrejmirtes
committed
Read assignment and class-constant-fetch type callbacks via getType/getNativeType
ondrejmirtes
committed
Read instanceof and coalesce type callbacks without the asking scope
ondrejmirtes
committed
Read assign-op type callback without the asking scope
ondrejmirtes
committed
Pass the iteratee types into enterForeach instead of re-reading them
ondrejmirtes
committed
Pass the iteratee types into enterForeachKey instead of re-reading them
ondrejmirtes
committed
Make the ExpressionResult typeCallback resolve from a native flag, not a scope
ondrejmirtes
committed
Require an ExpressionResult to have either a precomputed type or a typeCallback
ondrejmirtes
committed
Read the tracked holder directly in ExpressionResult, not via Scope::getType
ondrejmirtes
committed
Get rid of truthyScopeCallback and falseyScopeCallback
ondrejmirtes
committed
Use the operand's own truthy/falsey scope for &&/|| narrowing
ondrejmirtes
committed
Record conditional holders from by-ref-updated variables via scope state
ondrejmirtes
committed
Derive statement exit points from never instead of findEarlyTerminatingExpr
ondrejmirtes
committed
Narrower return type
ondrejmirtes
committed
Do not use getChildSpecifiedTypes
ondrejmirtes
committed
Inline getSpecifiedTypesForScope instead of getChildSpecifiedTypes
ondrejmirtes
committed
Keep getType for the dropped-self-condition complement
ondrejmirtes
committed
Add regression test for the type of a Closure::bind callback
ondrejmirtes
committed
Add regression test for array value type after foreach by-ref reassignment
ondrejmirtes
committed
Add regression test for list<non-empty-array> preserved after foreach by-ref
ondrejmirtes
committed
Add regression test for ??= on a dynamic property array offset
ondrejmirtes
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.