Accept lowercase IBANs in iban()#471
Open
sayantanmandal1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iban() treats lowercase input as well-formed (the regex has re.IGNORECASE and
[a-z0-9]) but then rejects it:
_char_value scores letters with 10 + ord(char) - ord("A"), which is only right
for uppercase, so lowercase letters get the wrong value and the mod-97 check
fails.
Upper-casing the char before scoring it fixes this. It only lets through inputs
that were already valid IBANs, so nothing that passed before changes. Added
lowercase and mixed-case cases to the tests.