Skip to content

gh-145854: Replace DELETE_NAME with PUSH_NULL; STORE_NAME#146006

Merged
markshannon merged 20 commits into
python:mainfrom
brijkapadia:delete-name
Jun 30, 2026
Merged

gh-145854: Replace DELETE_NAME with PUSH_NULL; STORE_NAME#146006
markshannon merged 20 commits into
python:mainfrom
brijkapadia:delete-name

Conversation

@brijkapadia

@brijkapadia brijkapadia commented Mar 16, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Changes

  • Removed DELETE_NAME
  • When STORE_NAME receives a NULL value, it corresponds with deletion

📚 Documentation preview 📚: https://cpython-previews--146006.org.readthedocs.build/

@brijkapadia
pythongh-145854: Replace DELETE_NAME with PUSH_NULL; STORE_NAME
1f97a49 
Changes
- Removed `DELETE_NAME`
- When `STORE_NAME` receives a `NULL` value, it corresponds with
  deletion
@bedevere-app bedevere-app Bot mentioned this pull request Mar 16, 2026
Open
@brijkapadia brijkapadia mentioned this pull request Mar 16, 2026
Open
@brijkapadia brijkapadia marked this pull request as draft March 16, 2026 02:31
@brijkapadia brijkapadia marked this pull request as ready for review March 16, 2026 10:39
@brijkapadia

brijkapadia commented Mar 16, 2026

Copy link
Copy Markdown
Contributor Author

I am not sure why three of the CIFuzz tests fail. If anyone could help, that would be appreciated.

picnixz
picnixz reviewed Mar 16, 2026
View reviewed changes
Comment thread Python/bytecodes.c Outdated
picnixz
picnixz reviewed Mar 16, 2026
View reviewed changes
Comment thread Python/bytecodes.c Outdated
@markshannon

markshannon commented Mar 16, 2026

Copy link
Copy Markdown
Member

This will need a magic number bump (as do all changes that add or remove opcodes)

@brijkapadia brijkapadia mentioned this pull request Mar 17, 2026
Open
markshannon
markshannon approved these changes Mar 17, 2026
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing this.

@brijkapadia

brijkapadia commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

@markshannon A gentle reminder about this PR.

@kumaraditya303

kumaraditya303 commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

A gentle reminder about this PR.

There are merge conflicts.

@python-cla-bot

python-cla-bot Bot commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@hugovk hugovk removed their request for review April 17, 2026 14:24
@markshannon

markshannon commented May 1, 2026

Copy link
Copy Markdown
Member

Sorry for leaving this sitting for so long.

I notice that _STORE_NAME is no longer suitable for jitting and is also quite large, so would bloat the stencils if it were.
Can you factor out the body of it into a _PyEval_StoreName() helper function?

@read-the-docs-community

read-the-docs-community Bot commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33374710 | 📁 Comparing 87c2898 against main (2a07ff9)

  🔍 Preview build  

254 files changed · + 6 added · ± 247 modified · - 1 deleted

+ Added

± Modified

- Deleted

@brijkapadia brijkapadia requested a review from markshannon May 29, 2026 16:52
@brijkapadia

brijkapadia commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

@markshannon A reminder about this PR, whenever you get a chance

markshannon
markshannon requested changes Jun 30, 2026
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing this.

I mistake in the magic number comment and needs merge conflicts fixing.
Otherwise, good to merge.

Comment thread Include/internal/pycore_magic_number.h Outdated
@bedevere-app

bedevere-app Bot commented Jun 30, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@brijkapadia

brijkapadia commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-app

bedevere-app Bot commented Jun 30, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

@bedevere-app bedevere-app Bot requested a review from markshannon June 30, 2026 13:44
markshannon
markshannon approved these changes Jun 30, 2026
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@markshannon markshannon merged commit c393ab6 into python:main Jun 30, 2026
83 of 86 checks passed
@brijkapadia brijkapadia deleted the delete-name branch June 30, 2026 16:33
@markshannon markshannon mentioned this pull request Jun 30, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments
@kumaraditya303 kumaraditya303 kumaraditya303 left review comments
@markshannon markshannon markshannon approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brijkapadia @markshannon @kumaraditya303 @picnixz