gh-149527: fix creation of temporary socket files post GH-148578#149597
Open
picnixz wants to merge 2 commits into
Open
gh-149527: fix creation of temporary socket files post GH-148578#149597picnixz wants to merge 2 commits into
picnixz wants to merge 2 commits into
Conversation
picnixz
added
needs backport to 3.13
picnixz
commented
May 9, 2026
Member
Author
|
@gpshead friendly ping |
gpshead
reviewed
Jul 7, 2026
Comment on lines
+154
to
+155
| # contains the socket file. Update _TMPPYMP_SUFFIXLEN accordingly | ||
| # if the random suffix length chosen by tempfile.mkdtemp() changes. |
Member
There was a problem hiding this comment.
is that controlled by us or the platform? would we remember to update this? a unittest that fails if tempfile.mkdtemp() uses a longer suffix length with an error message pointing here with instructions at least would flag it.
Member
Author
There was a problem hiding this comment.
By us. I will add a test when I have time!
gpshead
approved these changes
Jul 7, 2026
gpshead
left a comment
gpshead
left a comment
Member
There was a problem hiding this comment.
I think this looks overall correct, but it would be good if we could have a meaningful regression test around the max path length boundary cases to validate that the paths used remain short enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSError: AF_UNIX path too longregression inforkserver#149527