gh-152238: Revert gh-150490 and gh-152200.#152232
Merged
nascheme merged 1 commit intoJun 26, 2026
Merged
Conversation
Revert commits:
pythongh-151593: Fix dead lock in PyDict insert_split_key() (python#152200)
pythongh-150490: Raise PyType_Modified for insertion into split dictionary (python#150489)
For pythongh-150489, it violates locking discipline and results in deadlocks,
pythongh-151593 is an example of it being hit in CI. The attempted fix of
pythongh-152200 avoids the deadlock but introduces a data-race. The race
window is small but can be triggered with pure Python code.
nascheme
changed the title
methane
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert commits:
gh-151593: Fix dead lock in PyDict insert_split_key() (#152200)
gh-150490: Raise PyType_Modified for insertion into split dictionary (#150489)
For gh-150489, it violates locking discipline and results in deadlocks, gh-151593 is an example of it being hit in CI. The attempted fix of gh-152200 avoids the deadlock but introduces a data-race. The race window is small but can be triggered with pure Python code.