gh-135661: Fix abrupt closing of empty comment in HTMLParser#153007
Merged
serhiy-storchaka merged 1 commit intoJul 4, 2026
Conversation
An abruptly closed empty comment ("<!-->" or "<!--->") no longer extends
up to a later "-->" in the same feed() call.
test_htmlparser now also feeds each string source as a single chunk, in
addition to one character at a time, to exercise different input buffering.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
added
needs backport to 3.10
serhiy-storchaka
removed
needs backport to 3.10
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-153024 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-153025 is a backport of this pull request to the 3.14 branch. |
|
GH-153026 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 4, 2026
…H-153007) (GH-153026) An abruptly closed empty comment ("<!-->" or "<!--->") no longer extends up to a later "-->" in the same feed() call. test_htmlparser now also feeds each string source as a single chunk, in addition to one character at a time, to exercise different input buffering. (cherry picked from commit ed370d3) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 4, 2026
…H-153007) (GH-153025) An abruptly closed empty comment ("<!-->" or "<!--->") no longer extends up to a later "-->" in the same feed() call. test_htmlparser now also feeds each string source as a single chunk, in addition to one character at a time, to exercise different input buffering. (cherry picked from commit ed370d3) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 4, 2026
…H-153007) (GH-153024) An abruptly closed empty comment ("<!-->" or "<!--->") no longer extends up to a later "-->" in the same feed() call. test_htmlparser now also feeds each string source as a single chunk, in addition to one character at a time, to exercise different input buffering. (cherry picked from commit ed370d3) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An abruptly closed empty comment (
<!-->or<!--->) no longer extends up to a later-->in the samefeed()call.commentabruptcloseis now matched before searching for the normal-->/--!>close, so the empty comment does not swallow the following markup.This only showed up when the whole construct arrived in a single
feed()call, sotest_htmlparsernow also feeds each string source as a single chunk, in addition to one character at a time.