Skip to content

gh-152851: fix a crash when copying a BLAKE-2s/2b object #153008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 1 commit into from
Jul 4, 2026
+6 −1
Merged

gh-152851: fix a crash when copying a BLAKE-2s/2b object #153008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-07-04-11-14-06.gh-issue-152851.diYvTf.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Prevent a crash when allocation fails while copying a :func:`BLAKE-2s/2b
<hashlib.blake2b>` object. Patch by Bénédikt Tran.
5 changes: 4 additions & 1 deletion Modules/blake2module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,10 @@ blake2_blake2b_copy_unlocked(Blake2Object *self, Blake2Object *cpy)
} \
} while (0)

// Ensure that the implementation type is consistent with the HACL* state.
// See https://github.com/python/cpython/issues/152851 for details.
cpy->impl = self->impl;

switch (self->impl) {
#if _Py_HACL_CAN_COMPILE_VEC256
case Blake2b_256:
Expand All @@ -778,7 +782,6 @@ blake2_blake2b_copy_unlocked(Blake2Object *self, Blake2Object *cpy)
Py_UNREACHABLE();
}
#undef BLAKE2_COPY
cpy->impl = self->impl;
return 0;

error:
Expand Down
Loading