Skip to content

gh-153009: Fix compilation of curses on platforms that define the stdscr macro#153010

Merged
picnixz merged 2 commits into
python:mainfrom
picnixz:fix/curses/build-153009
Jul 4, 2026
Merged

gh-153009: Fix compilation of curses on platforms that define the stdscr macro#153010
picnixz merged 2 commits into
python:mainfrom
picnixz:fix/curses/build-153009

Conversation

@picnixz

@picnixz picnixz commented Jul 4, 2026

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are fast! LGTM. 👍

@picnixz

picnixz commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

I was fast because I needed that patch for another PR. It was a matter of splitting local work :')

@serhiy-storchaka

Copy link
Copy Markdown
Member

One small naming thought: std_screen reads a bit oddly since the field holds the stdscr window object inside a struct that's already a …ScreenObject — something like stdscr_win or std_win would say what it holds without colliding with the macro. Purely cosmetic, so feel free to keep std_screen if you prefer it.

@picnixz

picnixz commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

I like the stdscr_win

@picnixz picnixz merged commit cfe3e07 into python:main Jul 4, 2026
54 checks passed
@picnixz picnixz deleted the fix/curses/build-153009 branch July 4, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants