Skip to content

[3.14] gh-152851: fix a crash when copying a BLAKE-2s/2b object (GH-153008) #153012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 3 commits into from
Jul 4, 2026
+7 −1
Merged

[3.14] gh-152851: fix a crash when copying a BLAKE-2s/2b object (GH-153008) #153012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b51f41
[3.14] gh-152851: fix a crash when copying a BLAKE-2s/2b object (GH-1…
picnixz Jul 4, 2026
fc69eff
Apply suggestions from code review
picnixz Jul 4, 2026
3452fb2
Update Modules/blake2module.c
picnixz Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-07-04-11-14-06.gh-issue-152851.diYvTf.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Prevent a crash when allocation fails while copying a :func:`BLAKE-2s/2b
<hashlib.blake2b>` object. Patch by Bénédikt Tran.
6 changes: 5 additions & 1 deletion Modules/blake2module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,11 @@ static int
blake2_blake2b_copy_locked(Blake2Object *self, Blake2Object *cpy)
{
assert(cpy != NULL);

// Ensure that the implementation type is consistent with the HACL* state.
Comment thread
picnixz marked this conversation as resolved.
// See https://github.com/python/cpython/issues/152851 for details.
cpy->impl = self->impl;
Comment thread
picnixz marked this conversation as resolved.

switch (self->impl) {
#if _Py_HACL_CAN_COMPILE_VEC256
case Blake2b_256: {
Expand Down Expand Up @@ -768,7 +773,6 @@ blake2_blake2b_copy_locked(Blake2Object *self, Blake2Object *cpy)
default:
Py_UNREACHABLE();
}
cpy->impl = self->impl;
return 0;

error:
Expand Down
Loading