gh-59598: Ignore leading whitespace in JSONDecoder.raw_decode#153018
Closed
mayank-dev-15 wants to merge 1 commit into
Closed
gh-59598: Ignore leading whitespace in JSONDecoder.raw_decode#153018mayank-dev-15 wants to merge 1 commit into
mayank-dev-15 wants to merge 1 commit into
Conversation
raw_decode now ignores leading whitespace before the JSON value,
matching the behavior of decode(). Previously, passing a string like
' {}' to raw_decode would raise JSONDecodeError.
The fix uses the existing WHITESPACE regex to skip whitespace at
any offset, preserving correct behavior with the idx parameter.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
The following commit authors need to sign the Contributor License Agreement: |
Member
|
There is already an open PR. Please don't open PRs when there are already PRs, even if stale. It's polite to first ask the other PR's author if they are willing to continue their work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #59598
JSONDecoder.raw_decode()raisesJSONDecodeErroron strings with leading whitespace (e.g.,' {"key": "value"}'), whileJSONDecoder.decode()handles it fine. This is inconsistent behavior.Changes
raw_decode()to accept an optional_wparameter (defaulting toWHITESPACE.match) to skip leading whitespace before decodingdecode()to callraw_decode(s)instead of manually computing the whitespace end indexidxparameter — whitespace is skipped at any offset, not just the startBefore
After
Tests
Added
TestRawDecodetest class with tests for leading whitespace in raw_decode, covering both Python and C implementations.