Fix gh-152835: make inspect.signature robust to TYPE_CHECKING-only annotations#153055
Closed
raman118 wants to merge 1 commit into
Closed
Fix gh-152835: make inspect.signature robust to TYPE_CHECKING-only annotations#153055raman118 wants to merge 1 commit into
raman118 wants to merge 1 commit into
Conversation
…nly annotations
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
The following commit authors need to sign the Contributor License Agreement: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152835
This PR introduces a robust fallback mechanism in inspect.signature() to handle annotation evaluation failures (such as NameError, AttributeError, or ImportError).
When an exception is raised while evaluating parameter annotations under the default Format.VALUE format (common for annotations only imported in if TYPE_CHECKING: blocks), the logic now falls back to Format.FORWARDREF with eval_str=False, converting the failed references to ForwardRef objects instead of crashing. This prevents regressions for libraries and frameworks (like FastAPI, Pydantic, Click) that inspect signatures.