NXP backend: Enable amin with new Neutron flow

[roman-janik-nxp]

Summary

Add tests verifying correct support for amin by the Neutron backend using the new Neutron MLIR flow.

Test plan

Unit tests provided.

cc @robert-kalmar

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20549

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 123 Unrelated Failures

As of commit 368a3f2 with merge base e095c57 ():

NEW FAILURES - The following jobs have failed:

• Build documentation / build (buck2) / Build doc (gh)
  The process '/usr/bin/git' failed with exit code 128
• Build Presets / apple (macos) / build (gh)
  The process '/opt/homebrew/bin/git' failed with exit code 1
• Build Presets / apple (profiling) / build (gh)
  The process '/opt/homebrew/bin/git' failed with exit code 128
• Build Presets / linux (linux, linux.arm64.2xlarge, executorch-ubuntu-22.04-gcc11-aarch64) / build (gh)
  The process '/usr/bin/git' failed with exit code 128
• Build Presets / linux (pybind, linux.arm64.2xlarge, executorch-ubuntu-22.04-gcc11-aarch64) / build (gh)
  The process '/usr/bin/git' failed with exit code 1
• Build Presets / windows (windows) / build (gh)
  Process completed with exit code 1.
• pull / unittest / macos / macos-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• pull / unittest-editable / macos / macos-job (gh)
  The process '/usr/bin/git' failed with exit code 128

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

• periodic / test-models-linux (buck2, mv3, portable, linux.2xlarge, 90) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• periodic / test-models-linux (buck2, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• periodic / test-models-linux (cmake, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• periodic / test-models-linux (cmake, vit, portable, linux.2xlarge, 90) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• periodic / test-models-linux (cmake, vit, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / nxp-build-test / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-arm-backend-no-driver (test_pytest_ops_no_target) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-arm-cortex-m-size-test (bare_metal) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-arm-cortex-m-size-test (zephyr-preset) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-llama-runner-linux (fp32, xnnpack+custom+qe, linux.arm64.2xlarge, executorch-ubuntu-22.04-gc... / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-llama-runner-linux (fp32, xnnpack+custom+quantize_kv, linux.2xlarge, executorch-ubuntu-22.04... / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-llama-runner-linux (fp32, xnnpack+custom+quantize_kv, linux.arm64.2xlarge, executorch-ubuntu... / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-llama-runner-linux-android / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-llama-runner-qnn-linux (fp32, qnn_8a8w, qnn) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-lora-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-lora-multimethod-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-mcu-cortex-m-backend / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-mediatek-models-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-models-linux (add_mul, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-models-linux (ic3, portable, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (ic3, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (ic4, xnnpack-quantization-delegation, linux.4xlarge.memory) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-models-linux (mv2, portable, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-models-linux (mv2, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-models-linux (resnet18, portable, linux.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux-basic (mv3, portable, buck2, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux-basic (mv3, portable, cmake, linux.arm64.2xlarge, executorch-ubuntu-22.04-gcc11... / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux-basic (mv3, xnnpack-quantization-delegation, buck2, linux.2xlarge, executorch-u... / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-models-linux-basic (mv3, xnnpack-quantization-delegation, cmake, linux.2xlarge, executorch-u... / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux-basic (mv3, xnnpack-quantization-delegation, cmake, linux.arm64.2xlarge, execut... / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux-basic (vit, portable, buck2, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux-basic (vit, portable, cmake, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-models-linux-basic (vit, portable, cmake, linux.arm64.2xlarge, executorch-ubuntu-22.04-gcc11... / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux-basic (vit, xnnpack-quantization-delegation, cmake, linux.2xlarge, executorch-u... / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-models-linux-basic (vit, xnnpack-quantization-delegation, cmake, linux.arm64.2xlarge, execut... / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-moshi-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-parakeet-xnnpack-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-phi-3-mini-runner-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-qnn-buck-build-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-qnn-python-imports-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-qnn-testsuite-linux / test-backend-linux (qnn, operators) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-qnn-wheel-packages-linux (3.12) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-quantized-aot-lib-linux / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-static-llama-qnn-linux (stories_260k_bc) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• pull / unittest / linux / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / unittest-editable / linux / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / unittest-nxp-neutron / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128
• pull / unittest-wasm-bindings / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• Test QNN Backend / test-qnn / test-backend-linux (qnn, models) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1
• Test QNN Backend / test-qnn / test-backend-linux (qnn, operators) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 1

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• Build Presets / apple (ios-simulator) / build (gh) (trunk failure)
  The process '/opt/homebrew/bin/git' failed with exit code 128
• Build Presets / apple (ios) / build (gh) (trunk failure)
  The process '/opt/homebrew/bin/git' failed with exit code 1
• Build Presets / apple (pybind) / build (gh) (trunk failure)
  The process '/opt/homebrew/bin/git' failed with exit code 128
• Build Presets / linux (linux, linux.2xlarge, executorch-ubuntu-22.04-clang12) / build (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• Build Presets / linux (llm, linux.2xlarge, executorch-ubuntu-22.04-clang12) / build (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• Build Presets / linux (llm, linux.arm64.2xlarge, executorch-ubuntu-22.04-gcc11-aarch64) / build (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• Build Presets / linux (pybind, linux.2xlarge, executorch-ubuntu-22.04-clang12) / build (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• Build Presets / zephyr (zephyr) / build (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / android / build-android (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-arm-backend-no-driver (test_pytest_models_tosa) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-arm-backend-no-driver (test_pytest_ops_tosa) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-arm-backend-no-driver (test_run_tosa) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-arm-backend-public-api-backward-compatibility / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-binary-size-linux / linux-job (gh) (trunk failure)
• pull / test-binary-size-linux-gcc / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-build-wasm-linux / linux-job (gh) (trunk failure)
• pull / test-custom-ops-linux / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-eval_llama-wikitext-linux / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-llama_runner_eager-linux / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-llama-runner-linux (bf16, custom, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 128
• pull / test-llama-runner-linux (fp32, xnnpack+custom+qe, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-llama-runner-linux (fp32, xnnpack+quantize_kv, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-llama-runner-linux (fp32, xnnpack+quantize_kv, linux.arm64.2xlarge, executorch-ubuntu-22.04-... / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (add_mul, portable, linux.2xlarge) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (add, portable, linux.2xlarge) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (add, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (emformer_join, portable, linux.4xlarge.memory) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (emformer_join, xnnpack-quantization-delegation, linux.4xlarge.memory) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (emformer_transcribe, portable, linux.2xlarge) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (emformer_transcribe, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (trunk failure)
• pull / test-models-linux (ic4, portable, linux.4xlarge.memory) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (linear, portable, linux.2xlarge) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (linear, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (llama3_2_vision_encoder, portable, linux.4xlarge.memory) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (mobilebert, portable, linux.2xlarge) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (mobilebert, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (phi_4_mini, portable, linux.4xlarge.memory) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (resnet18, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (trunk failure)
• pull / test-models-linux (resnet50, portable, linux.2xlarge) / linux-job (gh) (trunk failure)
• pull / test-models-linux (resnet50, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux (w2l, portable, linux.4xlarge.memory) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux-basic (mv3, portable, cmake, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-models-linux-basic (vit, xnnpack-quantization-delegation, buck2, linux.2xlarge, executorch-u... / linux-job (gh) (trunk failure)
• pull / test-openvino-linux / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-qnn-delegate-linux / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-qnn-direct-build-linux / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-qnn-models-linux (dl3) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-qnn-models-linux (mv2) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-qnn-models-linux (mv3) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-qnn-passes-linux / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-qnn-testsuite-linux / test-backend-linux (qnn, models) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-qnn-wheel-packages-linux (3.10) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-qnn-wheel-packages-linux (3.11) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-qnn-wheel-packages-linux (3.13) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-selective-build-linux / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-setup-linux-gcc / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-sqnr-static-llm-qnn-linux (smollm2_135m) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-static-llama-qnn-linux (stories_110m) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-voxtral-realtime-xnnpack-linux / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• pull / test-vulkan-models-linux / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 128
• pull / unittest / windows / windows-job (gh) (trunk failure)
  Process completed with exit code 1.
• pull / unittest-buck / linux / linux-job (gh) (trunk failure)
• pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh) (trunk failure)
• Test ARM Backend / test-arm / test-backend-linux (arm_tosa_fp, models) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• Test ARM Backend / test-arm / test-backend-linux (arm_tosa_fp, operators) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• Test ARM Backend / test-arm / test-backend-linux (arm_vgf_fp, models) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• Test ARM Backend / test-arm / test-backend-linux (arm_vgf_fp, operators) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• Test Vulkan Backend / test-vulkan / test-backend-linux (vulkan, models) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• Test Vulkan Backend / test-vulkan / test-backend-linux (vulkan, operators) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• Test WebGPU Backend / test-webgpu / test-backend-linux (webgpu, models) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• Test WebGPU Backend / test-webgpu / test-backend-linux (webgpu, operators) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 128
• Test XNNPACK Backend / test-xnnpack / test-backend-linux (xnnpack, models) / linux-job (gh) (trunk failure)
  The process '/usr/bin/git' failed with exit code 1
• Test XNNPACK Backend / test-xnnpack / test-backend-linux (xnnpack, operators) / linux-job (gh) (trunk failure)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[linux-foundation-easycla]

• ❌ - login: @roman-janik-nxp / name: roman-janik-nxp. The commit (368a3f2) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please visit our EasyCLA portal and chat with our support bot.

[MartinPavella]

Well done for considering this case 👍🏻

Just FYI, NeutronPartitioner automatically tries to identify all no-ops by running every operator selected for delegation with random data. If it produces outputs that are exactly equal to the inputs (data, shape, type), it considers the node to be a no-op, and it will not delegate it as long as the operator is in a list of allowed no-ops. In the case of amin, I believe this system would have always correctly identified the no-ops, so simply adding the aten.amin into the list of allowed no-ops would have done the job.

But your solution is valid as well. No change needed.

[roman-janik-nxp]

Thanks, I learn from the best (you 😄 ). However I don't see any logic for said identifying in NeutronPartitioner and when I omit these checks in supports_partitioning_result() the tests fail. So I'm keeping it.

[MartinPavella]

Where did you find this requirement?

[roman-janik-nxp]

In your mean dim converter, I kept it, but I don't think it's necessary.

[MartinPavella]

It depends on the requirements of Neutron/Neutron IR. Often we can see requirements for equal input and output quantization here: https://developers.google.com/edge/litert/conversion/tensorflow/quantization/quantization_spec
The spec is, however, incomplete. It doesn't mention the ReduceMin operator. The Neutron documentation doesn't mention any such restrictions, so I think we should remove it. Also note that you used the shared quantization spec in our quantizer for the amin operator, so please update that too.

P.S.: We can handle mean later.