[ExecuTorch][WebGPU] Use requiredFeatures instance API on native + emscripten Dawn#20650
Open
JulianCloudNTH wants to merge 1 commit into
Open
[ExecuTorch][WebGPU] Use requiredFeatures instance API on native + emscripten Dawn#20650JulianCloudNTH wants to merge 1 commit into
JulianCloudNTH wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20650
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1cd76e3 with merge base 73c259e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 30, 2026
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Key the
timedWaitAnyinstance setup to the actual Dawn API instead of__EMSCRIPTEN__, so native-rig Dawn and emscripten/emdawnwebgpu use the modernrequiredFeaturespath and only the vendored Dawn uses the legacycapabilities.*path.The instance-descriptor setup was guarded by
#if defined(__EMSCRIPTEN__), which routed emscripten (emdawnwebgpu, emcc 4.0.19+) through the legacycapabilities.*API that no longer exists there. The guard now keys off the API actually present.Key changes:
WebGPUDevice.cpp—#if defined(__EMSCRIPTEN__)→#if defined(WEBGPU_DAWN_INSTANCE_CAPABILITIES). The legacyinstance_desc.capabilities.*path is taken only by the buck-vendored Dawn (which defines the macro); native cmake Dawn and emscripten leave it undefined and take therequiredFeatures/WGPUInstanceFeatureName_TimedWaitAnypath.Co-authored-with: Claude Code.
Differential Revision: D110149678