Skip to content

chore(deps): update rc-select to 1.9.0#648

Closed
Pareder wants to merge 1 commit into
react-component:masterfrom
Pareder:chore/update-rc-select
Closed

chore(deps): update rc-select to 1.9.0#648
Pareder wants to merge 1 commit into
react-component:masterfrom
Pareder:chore/update-rc-select

Conversation

@Pareder

@Pareder Pareder commented Jun 30, 2026

Copy link
Copy Markdown

Summary

  • updated @rc-component/select package to the latest minor version
  • updated tests to use click event instead of mousedown

Summary by CodeRabbit

  • Chores

    • 升级了一个底层选择组件依赖到较新的版本,带来更稳定的兼容性与后续改进支持。
  • Tests

    • 更新了相关清空操作的测试覆盖,确保单选和多选场景的清空行为保持一致。
    • 调整了测试触发方式,以更贴近实际点击交互。

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

@Pareder is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @rc-component/select dependency from version ~1.8.0 to ~1.9.0 in package.json. It also updates the test suite in tests/selector.spec.tsx by replacing fireEvent.mouseDown with fireEvent.click for the clear button interaction, and removes some trailing whitespace. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​rc-component/​select@​1.9.19810010099100

View full report

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 04586999-1e30-4d9f-a156-6321d4c8504d

📥 Commits

Reviewing files that changed from the base of the PR and between b7492d2 and 6e514c6.

📒 Files selected for processing (2)
  • package.json
  • tests/selector.spec.tsx

Walkthrough

package.json@rc-component/select 依赖从 ~1.8.0 升级至 ~1.9.0,同时将 tests/selector.spec.tsx 中三处清空按钮的触发事件由 fireEvent.mouseDown 改为 fireEvent.click,并移除一处空白行。

Changes

依赖升级与清空事件修复

Layer / File(s) Summary
依赖版本升级
package.json
@rc-component/select~1.8.0 升级为 ~1.9.0
清空按钮事件修复
tests/selector.spec.tsx
clear all 下的 singleShould clear activeCellsmultiple 三个场景中,清空按钮触发事件由 mouseDown 改为 click;另移除一处无逻辑影响的空白行。

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • zombieJ

🐰 小兔蹦跳来报喜,
清空一"click"更整齐,
依赖升级 1.9.0,
测试通过乐滋滋!
✨ Bug 再见,欢迎你~

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了此次依赖升级的主要变更,且与将 @rc-component/select 升级到 1.9.0 的内容基本一致。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

tests/selector.spec.tsx

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Pareder

Pareder commented Jun 30, 2026

Copy link
Copy Markdown
Author

Closed because it was already resolved in #649.

@Pareder Pareder closed this Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant