chore: update maintenance dependencies#1235
Conversation
|
Deployment failed with the following error: Learn More: https://vercel.com/react-component?upgradeToPro=build-rate-limit |
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the project to React 19 and TypeScript 6, introduces an ESLint flat configuration, and adds type compatibility declarations. While these changes facilitate the upgrade, several issues were identified regarding type safety and configuration. Specifically, disabling strict type-checking flags in tsconfig.json and globally overriding standard React types in react-compat.d.ts reduces codebase robustness and can cause type conflicts. Additionally, declaring test globals as any in global.d.ts overrides strongly-typed Jest definitions, a redundant type cast was found in legacyUtil.ts, and the custom ESLint rule filtering logic may silently discard intended TypeScript rules.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| if (next.rules) { | ||
| next.rules = Object.fromEntries( | ||
| Object.entries(next.rules).filter(([ruleName]) => { | ||
| if (!ruleName.startsWith('@typescript-eslint/')) { | ||
| return true; | ||
| } | ||
| return recommendedTsRules.has(ruleName) || ruleName === '@typescript-eslint/ban-types'; | ||
| }), | ||
| ); | ||
| } |
There was a problem hiding this comment.
This filtering logic silently discards any custom @typescript-eslint rules configured in .eslintrc.js that are not part of the recommended set. This can lead to unexpected behavior where intended lint rules are silently disabled without warning.
Instead of silently filtering rules in a helper function, consider explicitly disabling or overriding specific rules in the flat config array, or updating .eslintrc.js to remove deprecated rules.
| const { | ||
| key, | ||
| props: { children, value, ...restProps }, | ||
| } = node as React.ReactElement; | ||
| } = node as React.ReactElement<any>; |
There was a problem hiding this comment.
The cast as React.ReactElement<any> is redundant here because the node parameter is already explicitly typed as React.ReactElement<any> in the function signature.
| const { | |
| key, | |
| props: { children, value, ...restProps }, | |
| } = node as React.ReactElement; | |
| } = node as React.ReactElement<any>; | |
| const { | |
| key, | |
| props: { children, value, ...restProps }, | |
| } = node; |
| declare const describe: any; | ||
| declare const it: any; | ||
| declare const test: any; | ||
| declare const beforeEach: any; | ||
| declare const afterEach: any; | ||
| declare const beforeAll: any; | ||
| declare const afterAll: any; | ||
| declare const expect: any; |
There was a problem hiding this comment.
These global declarations override the strongly-typed Jest globals (provided by the <reference types="jest" /> directive at the top of the file) with any. This disables type safety and autocompletion in test files. Removing these declarations will restore proper typing for your tests.
| declare module 'react' { | ||
| type ReactText = string | number; | ||
| function useRef<T = undefined>(): React.MutableRefObject<T | undefined>; | ||
| function isValidElement<P = any>(object: {} | null | undefined): object is React.ReactElement<P>; | ||
| function cloneElement<P = any>( | ||
| element: React.ReactElement<P>, | ||
| props?: (Partial<P> & React.Attributes) | null, | ||
| ...children: React.ReactNode[] | ||
| ): React.ReactElement<P>; | ||
| } |
There was a problem hiding this comment.
Overriding standard React types globally via ambient module declaration (declare module 'react') is highly discouraged. It can cause subtle type conflicts for consumers of this library, especially when they use different React or TypeScript versions, or have strictNullChecks enabled.
Instead of global module augmentation, consider using local type assertions or utility types within the codebase where compatibility adjustments are needed.
| "noImplicitAny": false, | ||
| "strictNullChecks": false, | ||
| "strictPropertyInitialization": false, | ||
| "strictFunctionTypes": false, | ||
| "strict": false, | ||
| "noImplicitThis": false, | ||
| "strictBindCallApply": false |
There was a problem hiding this comment.
Disabling strict type checking flags (strict, strictNullChecks, noImplicitAny, etc.) reduces type safety and increases the risk of runtime errors (such as TypeError: Cannot read properties of undefined).
While upgrading to React 19 and TypeScript 6 can introduce type challenges, it is highly recommended to keep strict checks enabled and resolve the type errors properly to maintain codebase robustness.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
✅ Preview is ready!
↩️ Previous: ⚡️ 🤖 Powered by surge-preview |
|||||||||||||||
1 participant
Summary
Test Plan