Add image smoke-test examples and Maestro flows to RNTester (#57306)#57306
Open
Abbondanzo wants to merge 2 commits into
Open
Add image smoke-test examples and Maestro flows to RNTester (#57306)#57306Abbondanzo wants to merge 2 commits into
Abbondanzo wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109316705. |
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Jun 22, 2026
…eact#57306) Summary: Pull Request resolved: react#57306 Adds five Image examples to RNTester plus matching Maestro end-to-end flows, covering image-loading behaviors that previously had little or no RNTester coverage: - Progressive JPEG (`progressiveRenderingEnabled`) - `blurRadius` combined with `Image.prefetch` (blur postprocessor over a prefetched bitmap) - WebP (lossy/lossless/alpha) and AVIF format decoding - Image caching across a reload of the same URI (via `Image.queryCache`) - Wide-gamut (Display-P3) vs sRGB and alpha transparency Each example renders status text (load/error, cache status) with stable testIDs so the Maestro flows can assert behavior; the visual cases also capture screenshots. Examples that exercise Android-specific decoding (progressive JPEG, WebP/AVIF) are gated to Android; the rest run on both platforms. Format examples that lack a bundled asset (lossless/alpha WebP, AVIF, Display-P3) currently reference external sample URLs as a stopgap and render an onLoad/onError status so they degrade gracefully; these should be replaced with committed assets in a follow-up. Changelog: [Internal] Differential Revision: D109316705
Abbondanzo
force-pushed
the
export-D109316705
branch
from
3710ef8 to
2cda2d5
Compare
meta-codesync
Bot
changed the title
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Jun 22, 2026
…eact#57306) Summary: Pull Request resolved: react#57306 Adds five Image examples to RNTester plus matching Maestro end-to-end flows, covering image-loading behaviors that previously had little or no RNTester coverage: - Progressive JPEG (`progressiveRenderingEnabled`) - `blurRadius` combined with `Image.prefetch` (blur postprocessor over a prefetched bitmap) - WebP (lossy/lossless/alpha) and AVIF format decoding - Image caching across a reload of the same URI (via `Image.queryCache`) - Wide-gamut (Display-P3) vs sRGB and alpha transparency Each example renders status text (load/error, cache status) with stable testIDs so the Maestro flows can assert behavior; the visual cases also capture screenshots. Examples that exercise Android-specific decoding (progressive JPEG, WebP/AVIF) are gated to Android; the rest run on both platforms. Format examples that lack a bundled asset (lossless/alpha WebP, AVIF, Display-P3) currently reference external sample URLs as a stopgap and render an onLoad/onError status so they degrade gracefully; these should be replaced with committed assets in a follow-up. Changelog: [Internal] Differential Revision: D109316705
Abbondanzo
force-pushed
the
export-D109316705
branch
from
2cda2d5 to
f0cf94d
Compare
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Jun 22, 2026
…eact#57306) Summary: Pull Request resolved: react#57306 Adds five Image examples to RNTester plus matching Maestro end-to-end flows, covering image-loading behaviors that previously had little or no RNTester coverage: - Progressive JPEG (`progressiveRenderingEnabled`) - `blurRadius` combined with `Image.prefetch` (blur postprocessor over a prefetched bitmap) - WebP (lossy/lossless/alpha) and AVIF format decoding - Image caching across a reload of the same URI (via `Image.queryCache`) - Wide-gamut (Display-P3) vs sRGB and alpha transparency Each example renders status text (load/error, cache status) with stable testIDs so the Maestro flows can assert behavior; the visual cases also capture screenshots. Examples that exercise Android-specific decoding (progressive JPEG, WebP/AVIF) are gated to Android; the rest run on both platforms. Format examples that lack a bundled asset (lossless/alpha WebP, AVIF, Display-P3) currently reference external sample URLs as a stopgap and render an onLoad/onError status so they degrade gracefully; these should be replaced with committed assets in a follow-up. Changelog: [Internal] Differential Revision: D109316705
Abbondanzo
force-pushed
the
export-D109316705
branch
2 times, most recently
from
56be22f to
6a02b9b
Compare
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Jun 23, 2026
…eact#57306) Summary: Pull Request resolved: react#57306 Adds five Image examples to RNTester plus matching Maestro end-to-end flows, covering image-loading behaviors that previously had little or no RNTester coverage: - Progressive JPEG (`progressiveRenderingEnabled`) - `blurRadius` combined with `Image.prefetch` (blur postprocessor over a prefetched bitmap) - WebP (lossy/lossless/alpha) and AVIF format decoding - Image caching across a reload of the same URI (via `Image.queryCache`) - Wide-gamut (Display-P3) vs sRGB and alpha transparency Each example renders status text (load/error, cache status) with stable testIDs so the Maestro flows can assert behavior; the visual cases also capture screenshots. Examples that exercise Android-specific decoding (progressive JPEG, WebP/AVIF) are gated to Android; the rest run on both platforms. Format examples that lack a bundled asset (lossless/alpha WebP, AVIF, Display-P3) currently reference external sample URLs as a stopgap and render an onLoad/onError status so they degrade gracefully; these should be replaced with committed assets in a follow-up. Changelog: [Internal] Differential Revision: D109316705
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Jun 23, 2026
…eact#57306) Summary: Pull Request resolved: react#57306 Adds five Image examples to RNTester plus matching Maestro end-to-end flows, covering image-loading behaviors that previously had little or no RNTester coverage: - Progressive JPEG (`progressiveRenderingEnabled`) - `blurRadius` combined with `Image.prefetch` (blur postprocessor over a prefetched bitmap) - WebP (lossy/lossless/alpha) and AVIF format decoding - Image caching across a reload of the same URI (via `Image.queryCache`) - Wide-gamut (Display-P3) vs sRGB and alpha transparency Each example renders status text (load/error, cache status) with stable testIDs so the Maestro flows can assert behavior; the visual cases also capture screenshots. Examples that exercise Android-specific decoding (progressive JPEG, WebP/AVIF) are gated to Android; the rest run on both platforms. Format examples that lack a bundled asset (lossless/alpha WebP, AVIF, Display-P3) currently reference external sample URLs as a stopgap and render an onLoad/onError status so they degrade gracefully; these should be replaced with committed assets in a follow-up. Changelog: [Internal] Differential Revision: D109316705
Abbondanzo
force-pushed
the
export-D109316705
branch
from
6a02b9b to
419823b
Compare
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Jun 23, 2026
…eact#57306) Summary: Pull Request resolved: react#57306 Adds five Image examples to RNTester plus matching Maestro end-to-end flows, covering image-loading behaviors that previously had little or no RNTester coverage: - Progressive JPEG (`progressiveRenderingEnabled`) - `blurRadius` combined with `Image.prefetch` (blur postprocessor over a prefetched bitmap) - WebP (lossy/lossless/alpha) and AVIF format decoding - Image caching across a reload of the same URI (via `Image.queryCache`) - Wide-gamut (Display-P3) vs sRGB and alpha transparency Each example renders status text (load/error, cache status) with stable testIDs so the Maestro flows can assert behavior; the visual cases also capture screenshots. Examples that exercise Android-specific decoding (progressive JPEG, WebP/AVIF) are gated to Android; the rest run on both platforms. Format examples that lack a bundled asset (lossless/alpha WebP, AVIF, Display-P3) currently reference external sample URLs as a stopgap and render an onLoad/onError status so they degrade gracefully; these should be replaced with committed assets in a follow-up. Changelog: [Internal] Differential Revision: D109316705
Abbondanzo
force-pushed
the
export-D109316705
branch
from
419823b to
599697a
Compare
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Jun 23, 2026
…eact#57306) Summary: Pull Request resolved: react#57306 Adds four Image examples to RNTester plus matching Maestro end-to-end flows, covering image-loading behaviors that previously had little or no RNTester coverage: - Progressive JPEG (`progressiveRenderingEnabled`) - `blurRadius` combined with `Image.prefetch` (blur postprocessor over a prefetched bitmap) - Image caching across a reload of the same URI (via `Image.queryCache`) - Wide-gamut (Display-P3) vs sRGB and alpha transparency Each example renders status text (load/error, cache status) with stable testIDs so the Maestro flows can assert behavior; the visual cases also capture screenshots. Progressive JPEG is gated to Android (the prop is Android-only); the rest run on both platforms. The Display-P3 wide-gamut example references an external sample URL as a stopgap and renders an onLoad/onError status so it degrades gracefully; it should be replaced with a committed asset in a follow-up. Changelog: [Internal] Differential Revision: D109316705
Abbondanzo
force-pushed
the
export-D109316705
branch
from
599697a to
b0e42b8
Compare
Abbondanzo
changed the title
cortinico
approved these changes
Jun 24, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: The iOS RNTester Maestro suite is flaky because several flows assert the landing screen immediately after `launchApp`, with no wait. On a CI simulator the JS bundle hasn't rendered yet when the assertion fires, so flows fail with `Assertion is false: "Components" is visible` (e.g. `text`, `modal`) or fail downstream after entering through the shared launch helper (e.g. `pressable`). It is a race, not a deterministic failure — `flatlist`/`button` use the same pattern and pass on faster runs. Replace the bare landing-screen `assertVisible` with `extendedWaitUntil` (30s) so the bundle has time to render: - `helpers/launch-app-and-search.yml` (`Components`) — the shared entry path for `text`, `pressable`, `image`, and the new image smoke-test flows. - `modal.yml`, `flatlist.yml`, `button.yml` (`Components`). - `legacy-native-module.yml` (`APIs`). `extendedWaitUntil` returns as soon as the element appears, so this adds no time on the happy path — only headroom on cold start. This is the actual fix for the red iOS E2E; the earlier `spawnSync ETIMEDOUT` was the suite failing + retrying + occasionally overrunning the 10-minute per-attempt cap, not a simulator/driver-startup problem. No harness/setup changes. Changelog: [Internal] Differential Revision: D109742688
) Summary: Pull Request resolved: react#57306 Adds three Image examples to RNTester plus matching Maestro end-to-end flows, covering image-loading behaviors that previously had little or no RNTester coverage: - Progressive JPEG (`progressiveRenderingEnabled`) - `blurRadius` combined with `Image.prefetch` (blur postprocessor over a prefetched bitmap) - Wide-gamut (Display-P3) vs sRGB and alpha transparency Each example renders status text (load/error) with stable testIDs so the Maestro flows can assert behavior; the visual cases also capture screenshots. Progressive JPEG is gated to Android (the prop is Android-only); the rest run on both platforms. The Display-P3 wide-gamut example references an external sample URL as a stopgap and renders an onLoad/onError status so it degrades gracefully; it should be replaced with a committed asset in a follow-up. A fourth example/flow (image caching via `Image.queryCache`) was dropped from this diff because its iOS assertion is structurally flaky: iOS `queryCache` reflects only `NSURLCache`, so a cache hit depends on an HTTP-cacheable external host plus a cache-write timing race. It is deferred to T277258227. This diff is stacked on top of a prerequisite iOS Maestro harness fix (simulator boot-wait + driver-startup timeout + `--debug-output`); without it the iOS flows hang on simulator driver startup. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D109316705
Abbondanzo
force-pushed
the
export-D109316705
branch
from
b0e42b8 to
6f38662
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds three Image examples to RNTester plus matching Maestro end-to-end flows, covering image-loading behaviors that previously had little or no RNTester coverage:
progressiveRenderingEnabled)blurRadiuscombined withImage.prefetch(blur postprocessor over a prefetched bitmap)Each example renders status text (load/error) with stable testIDs so the Maestro flows can assert behavior; the visual cases also capture screenshots. Progressive JPEG is gated to Android (the prop is Android-only); the rest run on both platforms.
The Display-P3 wide-gamut example references an external sample URL as a stopgap and renders an onLoad/onError status so it degrades gracefully; it should be replaced with a committed asset in a follow-up.
A fourth example/flow (image caching via
Image.queryCache) was dropped from this diff because its iOS assertion is structurally flaky: iOSqueryCachereflects onlyNSURLCache, so a cache hit depends on an HTTP-cacheable external host plus a cache-write timing race. It is deferred to T277258227.This diff is stacked on top of a prerequisite iOS Maestro harness fix (simulator boot-wait + driver-startup timeout +
--debug-output); without it the iOS flows hang on simulator driver startup.Changelog:
[Internal]
Reviewed By: cortinico
Differential Revision: D109316705