Stabilize RNTester Maestro flows against app cold-start race#57343
Open
Abbondanzo wants to merge 1 commit into
Open
Stabilize RNTester Maestro flows against app cold-start race#57343Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109742688. |
Summary: The iOS RNTester Maestro suite is flaky because several flows assert the landing screen immediately after `launchApp`, with no wait. On a CI simulator the JS bundle hasn't rendered yet when the assertion fires, so flows fail with `Assertion is false: "Components" is visible` (e.g. `text`, `modal`) or fail downstream after entering through the shared launch helper (e.g. `pressable`). It is a race, not a deterministic failure — `flatlist`/`button` use the same pattern and pass on faster runs. Replace the bare landing-screen `assertVisible` with `extendedWaitUntil` (30s) so the bundle has time to render: - `helpers/launch-app-and-search.yml` (`Components`) — the shared entry path for `text`, `pressable`, `image`, and the new image smoke-test flows. - `modal.yml`, `flatlist.yml`, `button.yml` (`Components`). - `legacy-native-module.yml` (`APIs`). `extendedWaitUntil` returns as soon as the element appears, so this adds no time on the happy path — only headroom on cold start. This is the actual fix for the red iOS E2E; the earlier `spawnSync ETIMEDOUT` was the suite failing + retrying + occasionally overrunning the 10-minute per-attempt cap, not a simulator/driver-startup problem. No harness/setup changes. Changelog: [Internal] Differential Revision: D109742688
meta-codesync
Bot
changed the title
Abbondanzo
force-pushed
the
export-D109742688
branch
from
5fa3615 to
b351327
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The iOS RNTester Maestro suite is flaky because several flows assert the landing screen immediately after
launchApp, with no wait. On a CI simulator the JS bundle hasn't rendered yet when the assertion fires, so flows fail withAssertion is false: "Components" is visible(e.g.text,modal) or fail downstream after entering through the shared launch helper (e.g.pressable). It is a race, not a deterministic failure —flatlist/buttonuse the same pattern and pass on faster runs.Replace the bare landing-screen
assertVisiblewithextendedWaitUntil(30s) so the bundle has time to render:helpers/launch-app-and-search.yml(Components) — the shared entry path fortext,pressable,image, and the new image smoke-test flows.modal.yml,flatlist.yml,button.yml(Components).legacy-native-module.yml(APIs).extendedWaitUntilreturns as soon as the element appears, so this adds no time on the happy path — only headroom on cold start.This is the actual fix for the red iOS E2E; the earlier
spawnSync ETIMEDOUTwas the suite failing + retrying + occasionally overrunning the 10-minute per-attempt cap, not a simulator/driver-startup problem. No harness/setup changes.Changelog: [Internal]
Differential Revision: D109742688