Remove Community CLI platform config (upstreamed)#57353
Open
huntie wants to merge 2 commits into
Open
Conversation
Summary: Self-register commands from the `community-cli-plugin` package via `react-native.config.js` — meaning we can remove the redirect within `packages/react-native/react-native.config.js`. Progress towards removing `community-cli-plugin` as a direct dep of `react-native`, and paired with react-native-community/template#235. Changelog: [General][Breaking] - `react-native/community-cli-plugin` will no longer be auto-detected from `react-native`. It must now be specified in `devDependencies`. Differential Revision: D109869538
Summary: Depends on react-native-community/cli#2817. See also react-native-community/template#235. Progress towards deleting the `react-native.config.js` file we ship with `react-native`. These Community CLI plugins are moving back to being included by default (and in the first place, should not have been wired up here!). Changelog: [General][Changed] - Platform registration config for the Community CLI is removed from the `react-native` package. No breaking change with `react-native-community/cli` 21.x (required). Differential Revision: D109872883
meta-cla
Bot
added
the
CLA Signed
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109872883. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Depends on react-native-community/cli#2817. See also react-native-community/template#235.
Progress towards deleting the
react-native.config.jsfile we ship withreact-native. These Community CLI plugins are moving back to being included by default (and in the first place, should not have been wired up here!).Changelog:
[General][Changed] - Platform registration config for the Community CLI is removed from the
react-nativepackage. No breaking change withreact-native-community/cli21.x (required).Differential Revision: D109872883