Improve Ractor harness summary output#521
Open
eightbitraptor wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ractor harness runs every benchmark across a range of Ractor counts in a single process. So you get multiple benchmark results for running with 0, 1, 2... n Ractors in addition to the main Ractor.
However the Ractor harness was compressing that information to fit into the
samesummary table format as generated by the default harness. This resulted in the extra information being averaged across all runs. This has the effect of hidingthe impact of adding Ractor contention to the benchmark.
(The Ractor harness also contained a bug where millisecond timings were being used in calculations that assumed seconds, making the Ractor timings look orders of magnitudes larger than the other benchmarks in the run).
This PR fixes both issues by reformatting the table to include rows for each Ractor count when benchmarks are run with the Ractor harness
Example output
Numbers are illustrative only, this is for demonstrating formatting only