fix: throw a clear error when a media asset has no src#129
Open
dazzatronus wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restore a clean
tsconmain. The audio/image/video players and the timeline thumbnail renderer readasset.srcdirectly, but the generated@shotstack/schemastypes marksrcas optional — so each use was astring | undefinedtype error (7 in total). A red type-check gate also masks any genuinely new errors.How
Guard
srcat each point of use and throw an explicit… asset is missing a 'src'error — consistent with the existing invalid-source handling — which also narrows the type tostring. No changes to generated schema types, no!/asassertions.Behaviour
A media clip whose asset has no
srcnow fails with a clear error instead of building anundefined…URL and failing obscurely. A thumbnail for such a clip falls back to the existing solid-colour state.Verify
tsc --noEmitandtsc --project tsconfig.test.json --noEmitboth clean (pushed with the pre-push gate enabled, no bypass).