feat: post webhooks via the @slack/webhook SDK with action-side retries#630
Draft
zimeg wants to merge 6 commits into
Draft
feat: post webhooks via the @slack/webhook SDK with action-side retries#630zimeg wants to merge 6 commits into
zimeg wants to merge 6 commits into
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts both webhook techniques to the
@slack/webhookSDK and removesaxios/axios-retryas direct dependencies of the action:incoming-webhook→IncomingWebhookclasswebhook-trigger→WebhookTriggerclassRetry behavior (
0/5/10/RAPID) and HTTPS proxy support are preserved, so this is not a regression. Since the webhook SDK classes don't accept aretryConfig(unlikeWebClient), retries run in the action viap-retry, reusing@slack/web-api's named retry policies. Non-retryable responses (4xx other than 429) abort immediately; request errors and 5xx/429 are retried.src/config.jsno longer owns an axios client or builds the webhookUser-Agent— the SDKs set their own. The action still registers app metadata with@slack/web-api.@slack/webhookis pinned to a localfile:../node-slack-sdk/packages/webhookpath for development. It MUST be swapped to a published version (one that exportsWebhookTrigger) before this merges.Notes
@slack/web-apiversion bump in this PR;client.js(the API-method technique) is unchanged and still uses@slack/web-api@7(axios transitively).dist/is rebuilt as part of release, not committed here.Requirements
🤖 Generated with Claude Code