fix: allow cross-origin-isolation for the run endpoint#39
Merged
Conversation
|
|
Nemikolh
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After digging into the issues with
cross-origin-isolationand therunendpoint, I found out that the reason therunendpoint was not properly getting cross origin isolation because theiframewe created does not have asrcproperty. This means that it renders thisThat iframe then posts to the
/runendpoint. The problem is that thecross-origin-isolationis now allowingabout:blankto be cross-origin isolated, notstackblitz.com. So in order to fix this, we have to setallow="cross-origin-isolation https://stackblitz.com"explicitly.This PR also adds all the entire browser
allow-list.