fix(project): validate billingReference for standalone public projects#1456
Open
eloiberlinger1 wants to merge 3 commits into
Open
fix(project): validate billingReference for standalone public projects#1456eloiberlinger1 wants to merge 3 commits into
eloiberlinger1 wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds client-side validation to stackit project create so that creating a standalone PUBLIC project (i.e., without a Network Area) fails early with a clear error when the required billingReference label is missing, aligning CLI behavior with the governance requirements described in #1452.
Changes:
- Parse
--network-area-idearly during input parsing to support conditional label validation. - Add validation: if
scope=PUBLICand no network area is provided, require abillingReferencelabel.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+137
to
+146
| if scope, hasScope := (*labels)["scope"]; hasScope && scope == "PUBLIC" { | ||
| _, hasBilling := (*labels)["billingReference"] | ||
|
|
||
| if networkAreaId == nil && !hasBilling { | ||
| return nil, &errors.FlagValidationError{ | ||
| Flag: labelFlag, | ||
| Details: "creating a standalone public project (without a network area) requires a 'billingReference' label (e.g., --label billingReference=<value>)", | ||
| } | ||
| } | ||
| } |
Comment on lines
+137
to
+146
| if scope, hasScope := (*labels)["scope"]; hasScope && scope == "PUBLIC" { | ||
| _, hasBilling := (*labels)["billingReference"] | ||
|
|
||
| if networkAreaId == nil && !hasBilling { | ||
| return nil, &errors.FlagValidationError{ | ||
| Flag: labelFlag, | ||
| Details: "creating a standalone public project (without a network area) requires a 'billingReference' label (e.g., --label billingReference=<value>)", | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to #1452
Before the fix:
After the fix:
Note on Testing
Unfortunately because I only have a French phone number, I was unable to complete the project creation process to access the STACKIT Portal to check the payload validation conditions.
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)