group_ordering implementation#216
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new group_ordering API to ArrayKit that computes a stable grouping permutation and CSR-style group offsets for dense intp codes, along with tests, exports, and a performance benchmark harness entry.
Changes:
- Implemented
group_ordering(codes, *, size=None)in the C extension and registered it in the module. - Added comprehensive unit tests covering correctness, validation, immutability, and parity vs NumPy stable argsort.
- Added a performance benchmark entry for
group_orderingand exported the API in Python + stubs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_group_ordering.py | New unit tests validating group_ordering behavior and edge cases. |
| src/methods.h | Adds the C API declaration for group_ordering. |
| src/methods.c | Implements group_ordering via stable counting sort producing perm + offsets. |
| src/_arraykit.c | Registers group_ordering in the extension module method table. |
| src/init.pyi | Adds typing stub for group_ordering. |
| src/init.py | Re-exports group_ordering from the extension module. |
| performance/main.py | Adds group_ordering benchmark classes (AK vs REF). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.