Skip to content

fix: ensure stdlib_float16_bits_t is defined for all stdlib_float16_t type definitions#13162

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
sathwikv2005:fix/float16-bits-typedef
Jun 28, 2026
Merged

fix: ensure stdlib_float16_bits_t is defined for all stdlib_float16_t type definitions#13162
kgryte merged 1 commit into
stdlib-js:developfrom
sathwikv2005:fix/float16-bits-typedef

Conversation

@sathwikv2005

@sathwikv2005 sathwikv2005 commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Resolves #13147.

Description

What is the purpose of this pull request?

This pull request:

  • fixes the conditional definition of stdlib_float16_bits_t in ctor.h.
  • moves the stdlib_float16_bits_t typedef outside the native _Float16 detection conditional so, that it is available on compilers with native _Float16 support, matching the documented API.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@sathwikv2005 sathwikv2005 requested a review from a team June 27, 2026 08:34
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 27, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
number/float16/ctor $\\color{green}331/331$
$\\color{green}+100.00\\%$
$\\color{green}13/13$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}331/331$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 28, 2026
@kgryte kgryte changed the title fix(float16): define stdlib_float16_bits_t for native _Float16 fix: ensure stdlib_float16_bits_t is defined for all stdlib_float16_t type definitions Jun 28, 2026
@kgryte kgryte merged commit 6a1979f into stdlib-js:develop Jun 28, 2026
46 checks passed
@sathwikv2005 sathwikv2005 deleted the fix/float16-bits-typedef branch June 28, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: stdlib_float16_bits_t is conditionally undefined on compilers with native Float16 support

3 participants