bench: add missing function documentation and ensure consistency with other benchmarks#13221
Merged
Merged
Conversation
…ing packages Add missing function documentation comments and use the `y != y` self-comparison idiom for NaN checks (dropping the now-unused `<math.h>` include), matching the C benchmark scaffold used by the other stats/base/dists packages added in this window (poisson/entropy, lognormal/logpdf, log-logistic/pdf).
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jul 1, 2026
stats/base/dists/anglit/quantile C benchmark with sibling packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for commits merged to
developbetween 2026-06-30 14:47 PDT (14c51b7f3) and 2026-07-01 01:30 CDT (aebd92a2a).Description
Small style follow-ups against the eight commits merged to
developin the last 24 hours. Onlystats/base/dists/anglit/quantileneeded changes; the other three new distribution packages (poisson/entropyC addition,lognormal/logpdfC addition,log-logistic/pdf) and the four bot/namespace commits came in clean.Fixes in this PR:
quantilebenchmark lacked the/** ... */doc comments every sibling benchmark.c uses. Added matching doc comments toprint_version,print_summary,print_results,tic,random_uniform,benchmark, andmain. (aebd92a2a,lib/node_modules/@stdlib/stats/base/dists/anglit/quantile/benchmark/c/benchmark.c)isnan( y )inlib/node_modules/@stdlib/stats/base/dists/anglit/quantile/benchmark/c/benchmark.cbroke with the tree's establishedy != yself-comparison idiom for NaN checks, dragging in an unneeded<math.h>. Switched both call sites toy != yand dropped the include. (aebd92a2a,lib/node_modules/@stdlib/stats/base/dists/anglit/quantile/benchmark/c/benchmark.c)Related Issues
None.
Questions
No.
Other
Validation. Reviewed all eight commits merged to
developin the window with four parallel reviewers (two style, two bug-hunt). Checked for stdlib code style compliance, copy-paste artefacts, math/logic bugs, boundary handling, contract mismatches, wrong constants, and manifest/addon wiring. Findings that were not independently re-verifiable against a sibling reference package, or that would require touching code outside the window's diff, were deliberately excluded. The three sibling C benchmarks added in the same window (poisson/entropy,lognormal/logpdf,log-logistic/pdf) served as the reference for the anglit benchmark fix.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of a scheduled routine that audits recent commits to
develop. The reviewer agents surfaced the two style deviations above; the fixes mirror the doc-comment scaffold and NaN-check idiom already used by the three sibling C benchmarks added in the same window.@stdlib-js/reviewers
Generated by Claude Code