Skip to content

feat: add float16 dtype support for array/base/getter#13223

Merged
kgryte merged 3 commits into
stdlib-js:developfrom
gururaj1512:float16-support/array/base/getter
Jul 1, 2026
Merged

feat: add float16 dtype support for array/base/getter#13223
kgryte merged 3 commits into
stdlib-js:developfrom
gururaj1512:float16-support/array/base/getter

Conversation

@gururaj1512

Copy link
Copy Markdown
Member

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • feat: add float16 dtype support for array/base/getter

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@gururaj1512 gururaj1512 requested a review from a team July 1, 2026 18:05
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 1, 2026
@stdlib-bot

stdlib-bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/base/getter $\\color{green}350/350$
$\\color{green}+0.00\\%$
$\\color{green}17/17$
$\\color{green}+0.00\\%$
$\\color{green}13/13$
$\\color{green}+0.00\\%$
$\\color{green}350/350$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Jul 1, 2026
Comment thread lib/node_modules/@stdlib/array/base/getter/docs/types/index.d.ts Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/array/base/getter/docs/types/test.ts
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up. @gururaj1512 Please make sure you are investigating lint failures. Yes, for some of your work, such as in the plot refactor, we effectively ignore, but all failures should be investigated regardless in order to eliminate the possibility of human error. If you don't, just requires additional clean-up and increases the likelihood of bugs.

@kgryte kgryte changed the title feat: add float16 dtype support for array/base/getter feat: add float16 dtype support for array/base/getter Jul 1, 2026
@kgryte kgryte merged commit c38afb1 into stdlib-js:develop Jul 1, 2026
13 checks passed
@gururaj1512 gururaj1512 deleted the float16-support/array/base/getter branch July 2, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants