Skip to content

test(tdg): await data model readiness in TDGClientTest#107

Merged
MaxSiominDev merged 1 commit into
masterfrom
TNTP-8445-await-tdg-model-readiness
Jul 3, 2026
Merged

test(tdg): await data model readiness in TDGClientTest#107
MaxSiominDev merged 1 commit into
masterfrom
TNTP-8445-await-tdg-model-readiness

Conversation

@MaxSiominDev

Copy link
Copy Markdown
Contributor

TDGClientTest queried spaces right after cluster.start(), which only waits for the containers to come up. The TDG data model (and therefore the User/person spaces) is applied asynchronously afterwards, so on slower runners the first queries hit a not-yet-created space and failed with "attempt to index ... 'space' (a nil value)". Wait for the model in @BeforeAll by probing both spaces via retryUntilSuccess before the tests run.

I haven't forgotten about:

  • Tests
  • Changelog
  • Documentation
    • JavaDoc was written
  • Commit messages comply with the guideline
  • Cleanup the code for review. See checklist

Related issues:

@MaxSiominDev MaxSiominDev force-pushed the TNTP-8445-await-tdg-model-readiness branch from d06cb25 to ba606ba Compare July 2, 2026 15:36
TDGClientTest queried spaces right after cluster.start(), which only waits for the containers to come up. The TDG data model (and therefore the User/person spaces) is applied asynchronously afterwards, so on slower runners the first queries hit a not-yet-created space and failed with "attempt to index ... 'space' (a nil value)". Wait for the model in @BeforeAll by probing both spaces via retryUntilSuccess before the tests run.
@MaxSiominDev MaxSiominDev force-pushed the TNTP-8445-await-tdg-model-readiness branch from ba606ba to 57b7450 Compare July 2, 2026 23:40
@MaxSiominDev MaxSiominDev marked this pull request as ready for review July 2, 2026 23:40
Copilot AI review requested due to automatic review settings July 2, 2026 23:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Stabilizes TDGClientTest integration tests by ensuring the Tarantool Data Grid data model is fully applied before any test queries run, avoiding intermittent failures on slower CI runners.

Changes:

  • Add a readiness wait in @BeforeAll that retries until both User and person spaces are queryable.
  • Introduce a dedicated timeout constant and supporting imports for the readiness retry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MaxSiominDev MaxSiominDev merged commit 5f8ca31 into master Jul 3, 2026
7 checks passed
@MaxSiominDev MaxSiominDev deleted the TNTP-8445-await-tdg-model-readiness branch July 3, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants