chore: add testbox workflows and scripts#4071
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
WalkthroughTwo GitHub Actions workflows were added for Blacksmith Testbox CI, one for Linux and one for Windows. Both are manually triggered with a required 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/pr-testbox.yml (1)
47-48: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick winUse
sudofor the/etc/dockerdirectory creation.Line 47 can fail with a permission error on runners where
/etc/dockerdoes not already exist, which makes the Docker reconfiguration path brittle before the daemon restart.Suggested fix
- mkdir -p /etc/docker + sudo mkdir -p /etc/docker echo "$CONFIG" | sudo tee /etc/docker/daemon.json
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 1648f337-c0fd-4238-9d3a-602c92b7db0c
📒 Files selected for processing (2)
.github/workflows/pr-testbox-windows.yml.github/workflows/pr-testbox.yml
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
- GitHub Check: typecheck / typecheck
🔇 Additional comments (2)
.github/workflows/pr-testbox.yml (1)
125-127: 🎯 Functional Correctness
run-testboxdoes not need a command here
useblacksmith/run-testboxis the Testbox handoff/idle monitor; it does not acceptscripts/test-pr-check.shas an input, so this step is fine as-is.> Likely an incorrect or invalid review comment..github/workflows/pr-testbox-windows.yml (1)
21-21: LGTM!Also applies to: 57-57
Needed to trigger Blacksmith Testbox workflows.