Skip to content

Fixing flaky integration test: TestCrashAfterRejectDoesNotLoseMessages #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
behinddwalls merged 1 commit into from
Jun 25, 2026
+8 −1
Merged

Fixing flaky integration test: TestCrashAfterRejectDoesNotLoseMessages #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion test/integration/extension/messagequeue/mysql/queue_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2221,10 +2221,12 @@ func (s *SQLQueueIntegrationSuite) TestCrashAfterRejectDoesNotLoseMessages() {

// Start worker-2 with same consumer group — it polls and finds msg-C
// after lease + visibility expire in the DB
signalCh := make(chan queueMySQL.HookSignal, 100)
q2, err := queueMySQL.NewQueue(queueMySQL.Params{
DB: s.db,
Logger: zaptest.NewLogger(t),
MetricsScope: tally.NoopScope,
OnSignal: signalCh,
})
require.NoError(t, err)
defer q2.Close()
Expand All @@ -2243,6 +2245,9 @@ func (s *SQLQueueIntegrationSuite) TestCrashAfterRejectDoesNotLoseMessages() {
require.NoError(t, delivery.Ack(s.ctx))
t.Logf("Worker-2 recovered msg-C (attempt=%d)", delivery.Attempt())

// Wait for the poll loop to advance the watermark after acking msg-C.
waitForSignal(t, signalCh, queueMySQL.SignalDeliveryCheck)

// Verify DLQ contains msg-B
dlqTopic := topic + subConfig.DLQ.TopicSuffix
dlqConfig := extqueue.DefaultSubscriptionConfig("worker-2", "crash-reject-cg")
Expand All @@ -2254,7 +2259,9 @@ func (s *SQLQueueIntegrationSuite) TestCrashAfterRejectDoesNotLoseMessages() {
assert.Equal(t, "msg-B", dlqDelivery.Message().ID, "msg-B should be in DLQ")
require.NoError(t, dlqDelivery.Ack(s.ctx))

// Verify consumer lag is 0
// Verify consumer lag is 0.
// Wait for the poll loop so advanceWatermark has run after all acks.
waitForSignal(t, signalCh, queueMySQL.SignalDeliveryCheck)
admin := queueAdmin.NewAdminStore(s.db)
lags, err := admin.ConsumerLag(s.ctx, topic)
require.NoError(t, err)
Expand Down
Loading