docs: document pkg.pr.new preview builds#1965
Conversation
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
✅ Staging deployment successful! Preview: https://viteplus-staging.void.app/ |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53312621ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fengmk2
force-pushed
the
codex/document-pkg-pr-new-preview-builds
branch
from
5331262 to
598f2e4
Compare
fengmk2
force-pushed
the
codex/document-pkg-pr-new-preview-builds
branch
from
598f2e4 to
19a2ef5
Compare
|
Addressed the review feedback in 19a2ef5:
Verification: |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
|
||
| Only include the direct `vite` entry if your project already has one. If your project has `@voidzero-dev/vite-plus-core` directly instead, update that package spec to the same core preview URL. | ||
|
|
||
| For pnpm workspaces, make the same temporary override change in `pnpm-workspace.yaml` if that is where your Vite+ overrides live: |
There was a problem hiding this comment.
Needed when the preview package depends on other pkg.pr.new preview URLs.
blockExoticSubdeps: false
| - any direct `vite` alias or direct `@voidzero-dev/vite-plus-core` dependency should point at `https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@<pr-or-sha>` | ||
| - any `vite` override or resolution should point at that same core preview URL | ||
|
|
||
| For npm and Bun projects, update the relevant `package.json` entries: |
There was a problem hiding this comment.
Wait for #1891 merged, then use the registry bridge.
There is a compatibility issue when bun overrides the http url version. It will decompress and read the name field in the package.json inside to verify. If it finds that it is not vite, it will invalidate the overrides rule, causing vitest to install the peer version of vite that it declares.
There was a problem hiding this comment.
we should probably document this somehow. do you think this is worth raising this in bun?
There was a problem hiding this comment.
@TheAlexLichter Yes, I will create a minimal reproduction repo before merging and then submit it to bun.
2 participants
Closes #1929