feat(test): PTY-based interactive CLI snapshot tests by fengmk2 · Pull Request #2052 · voidzero-dev/vite-plus

fengmk2 · 2026-07-05T01:41:42Z

Implements the RFC included in this PR as rfcs/interactive-snapshot-tests.md.

crates/vite_cli_snapshots: PTY-based CLI snapshot suite (libtest-mimic). Every step runs in a real pseudo-terminal with vt100 grid capture; interactive steps script keystrokes synchronized on OSC 8 milestones; snapshots are Markdown with real pass/fail semantics (UPDATE_SNAPSHOTS=1 to accept, .md.new plus unified diff on mismatch). Built on the pty_terminal/snapshot_test crates from vite-task at the already-pinned rev.
One fixture tree replaces the local/global split: each case declares vp = "local" | "global" | ["local", "global"]; the parity matrix already caught real drift between the two help outputs. Per-case VP_HOME/HOME/npm-prefix isolation removes serial and the bootstrap byte-match requirement; seed-runtime symlinks a provisioned managed runtime; failure flow is shell-like with line boundaries (continue-on-failure).
vpt test multitool (vtt-aligned subcommands plus json-edit, chmod, probe) so fixtures run without a shell and behave identically on every platform.
tool migrate-snap-tests <dir> --vp <flavor> [filter]: one-click migration of old steps.json cases with a report; TODO-free conversions auto-remove the legacy dir. Migrated so far: the four check-pass* cases, cli-helper-message (local + global merged into one fixture), and build-vite-env.
packages/prompts: milestone emission for select/confirm/text, gated on VP_EMIT_MILESTONES=1, byte-identical to the vite-task protocol; render output unchanged when disabled.
CI: dedicated CLI snapshot test jobs for Linux, macOS, and Windows (Windows runs a cross-compiled nextest archive, no Rust toolchain on the runner); snapshot-baseline-only changes still trigger CI despite the markdown filters.
Entry points: just snapshot-test [filter], just snapshot-test-global (no JS build needed), pnpm snapshot-test. Contributor docs: crates/vite_cli_snapshots/tests/cli_snapshots/README.md.

Validation: 14 snapshot trials plus redaction/migrator/prompt unit suites pass in compare mode on all three CI platforms.

Follow-ups per the RFC phasing: local-registry case support, remaining prompt components (multiselect, password, spinner), migration batches, legacy runner removal.

netlify · 2026-07-05T01:41:47Z

✅ Deploy Preview for viteplus-preview ready!

Name	Link
🔨 Latest commit	`603140d`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/6a4ba93bd3d35000088d97c9
😎 Deploy Preview	https://deploy-preview-2052--viteplus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

fengmk2 · 2026-07-05T01:41:57Z

How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

socket-security · 2026-07-05T01:44:14Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	cargo/nix@0.28.0
	cargo/winreg@0.10.1
	cargo/cp_r@0.5.2
	cargo/toml@1.1.2%2Bspec-1.1.0
	cargo/libtest-mimic@0.8.2

View full report

fengmk2 · 2026-07-05T14:54:37Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e9b7db0e78

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-05T15:34:04Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d9bd36a53

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-05T15:54:03Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b1294289f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-05T16:17:46Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7ce35c142f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-05T16:44:18Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 23a5d0b7f2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-05T17:12:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f046797698

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-05T17:34:22Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bfad895b80

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-05T18:01:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7660d0533f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-05T18:16:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df5abf79ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-06T00:54:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df5abf79ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-06T01:26:12Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b750991666

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-06T02:08:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ab99aad510

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-06T02:36:38Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 222abdcc73

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-06T03:02:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c060a5d7e1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 · 2026-07-06T03:21:01Z

@codex review

chatgpt-codex-connector · 2026-07-06T03:28:12Z

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 37803835e7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

graphite-app · 2026-07-06T13:09:57Z

Merge activity

Jul 6, 1:09 PM UTC: fengmk2 added this pull request to the Graphite merge queue.
Jul 6, 1:27 PM UTC: Merged by the Graphite merge queue.

Implements the RFC included in this PR as `rfcs/interactive-snapshot-tests.md`. - `crates/vite_cli_snapshots`: PTY-based CLI snapshot suite (libtest-mimic). Every step runs in a real pseudo-terminal with vt100 grid capture; interactive steps script keystrokes synchronized on OSC 8 milestones; snapshots are Markdown with real pass/fail semantics (`UPDATE_SNAPSHOTS=1` to accept, `.md.new` plus unified diff on mismatch). Built on the pty_terminal/snapshot_test crates from vite-task at the already-pinned rev. - One fixture tree replaces the local/global split: each case declares `vp = "local" | "global" | ["local", "global"]`; the parity matrix already caught real drift between the two help outputs. Per-case `VP_HOME`/`HOME`/npm-prefix isolation removes `serial` and the bootstrap byte-match requirement; `seed-runtime` symlinks a provisioned managed runtime; failure flow is shell-like with line boundaries (`continue-on-failure`). - `vpt` test multitool (vtt-aligned subcommands plus `json-edit`, `chmod`, `probe`) so fixtures run without a shell and behave identically on every platform. - `tool migrate-snap-tests <dir> --vp <flavor> [filter]`: one-click migration of old `steps.json` cases with a report; TODO-free conversions auto-remove the legacy dir. Migrated so far: the four `check-pass*` cases, `cli-helper-message` (local + global merged into one fixture), and `build-vite-env`. - `packages/prompts`: milestone emission for `select`/`confirm`/`text`, gated on `VP_EMIT_MILESTONES=1`, byte-identical to the vite-task protocol; render output unchanged when disabled. - CI: dedicated `CLI snapshot test` jobs for Linux, macOS, and Windows (Windows runs a cross-compiled nextest archive, no Rust toolchain on the runner); snapshot-baseline-only changes still trigger CI despite the markdown filters. - Entry points: `just snapshot-test [filter]`, `just snapshot-test-global` (no JS build needed), `pnpm snapshot-test`. Contributor docs: `crates/vite_cli_snapshots/tests/cli_snapshots/README.md`. Validation: 14 snapshot trials plus redaction/migrator/prompt unit suites pass in compare mode on all three CI platforms. Follow-ups per the RFC phasing: `local-registry` case support, remaining prompt components (multiselect, password, spinner), migration batches, legacy runner removal.

fengmk2 commented Jul 5, 2026

View reviewed changes

Comment thread rfcs/interactive-snapshot-tests.md Outdated

fengmk2 self-assigned this Jul 5, 2026

fengmk2 mentioned this pull request Jul 5, 2026

feat(cli): global -C flag for working-directory switching #2031

Draft

fengmk2 force-pushed the rfc/interactive-snapshot-tests branch from fefbe9d to e6ed290 Compare July 5, 2026 06:10

chatgpt-codex-connector Bot reviewed Jul 5, 2026

View reviewed changes

Comment thread crates/vite_cli_snapshots/tests/cli_snapshots/redact.rs Outdated

Comment thread justfile

Comment thread crates/vite_cli_snapshots/tests/cli_snapshots/flavor.rs Outdated

Comment thread crates/vite_cli_snapshots/tests/cli_snapshots/redact.rs

chatgpt-codex-connector Bot reviewed Jul 5, 2026

View reviewed changes

Comment thread packages/tools/src/migrate-snap-tests.ts

Comment thread crates/vite_cli_snapshots/tests/cli_snapshots/flavor.rs Outdated

Comment thread packages/tools/src/migrate-snap-tests.ts Outdated

chatgpt-codex-connector Bot reviewed Jul 5, 2026

View reviewed changes

Comment thread justfile

chatgpt-codex-connector Bot reviewed Jul 5, 2026

View reviewed changes

Comment thread crates/vite_cli_snapshots/tests/cli_snapshots/fixtures/build_vite_env/snapshots.toml

chatgpt-codex-connector Bot reviewed Jul 6, 2026

View reviewed changes

Comment thread crates/vite_cli_snapshots/tests/cli_snapshots/flavor.rs Outdated

Comment thread packages/tools/src/migrate-snap-tests.ts

Comment thread packages/tools/src/migrate-snap-tests.ts

chatgpt-codex-connector Bot reviewed Jul 6, 2026

View reviewed changes

fengmk2 changed the title ~~feat(test): PTY-based interactive CLI snapshot harness~~ feat(test): PTY-based interactive CLI snapshot tests Jul 6, 2026

chatgpt-codex-connector Bot reviewed Jul 6, 2026

View reviewed changes

Comment thread packages/tools/src/migrate-snap-tests.ts Outdated

Comment thread crates/vite_cli_snapshots/tests/cli_snapshots/main.rs Outdated

Comment thread crates/vite_cli_snapshots/src/bin/vpt/chmod.rs

chatgpt-codex-connector Bot reviewed Jul 6, 2026

View reviewed changes

Comment thread crates/vite_cli_snapshots/src/bin/vpt/grep_file.rs Outdated

Comment thread crates/vite_cli_snapshots/tests/cli_snapshots/flavor.rs

Comment thread crates/vite_cli_snapshots/src/bin/vpt/print_file.rs

chatgpt-codex-connector Bot reviewed Jul 6, 2026

View reviewed changes

fengmk2 requested a review from wan9chi July 6, 2026 03:25

fengmk2 force-pushed the rfc/interactive-snapshot-tests branch from 3780383 to 4f8f1d5 Compare July 6, 2026 03:58

fengmk2 marked this pull request as ready for review July 6, 2026 04:36

fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests preview-build Publish this PR's commits to the registry bridge as preview builds test: sfw labels Jul 6, 2026

fengmk2 force-pushed the rfc/interactive-snapshot-tests branch from 94a3433 to b62a903 Compare July 6, 2026 06:06

wan9chi approved these changes Jul 6, 2026

View reviewed changes

graphite-app Bot force-pushed the rfc/interactive-snapshot-tests branch from b62a903 to 603140d Compare July 6, 2026 13:10

graphite-app Bot merged commit 603140d into main Jul 6, 2026
101 of 102 checks passed

graphite-app Bot deleted the rfc/interactive-snapshot-tests branch July 6, 2026 13:27

Uh oh!

Conversation

fengmk2 commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview ready!

Uh oh!

fengmk2 commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

socket-security Bot commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

fengmk2 commented Jul 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengmk2 commented Jul 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengmk2 commented Jul 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengmk2 commented Jul 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengmk2 commented Jul 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengmk2 commented Jul 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

fengmk2 commented Jul 5, 2026 •

edited

Loading

netlify Bot commented Jul 5, 2026 •

edited

Loading

fengmk2 commented Jul 5, 2026 •

edited

Loading

socket-security Bot commented Jul 5, 2026 •

edited

Loading