React Native 0.85#8
Open
JP (jpdriver) wants to merge 2 commits into
Open
Conversation
JP (jpdriver)
force-pushed
the
jpdriver/main
branch
from
7567b8e to
bdb1521
Compare
Stephanie Cure Chegwin (Scure21)
requested a review
from Luis Camargo (LuisCamargoM)
| Use the localStorage polyfill for key-value storage. **Never use AsyncStorage** | ||
|
|
||
| ```tsx | ||
| import "expo-sqlite/localStorage/install"; |
Collaborator
There was a problem hiding this comment.
Why is it preferred to use the polyfill Vs expo-sqlite/kv-store for key-value storage?
Stephanie Cure Chegwin (Scure21)
left a comment
Stephanie Cure Chegwin (Scure21)
left a comment
Collaborator
There was a problem hiding this comment.
Wow JP this is amazing! so many good guidances in the skills and the docs/adr is fantastic! Thank you for doing this!
I'm still reviewing but will finish today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(wasn't able to push this directly to
maindue to the TruffleHog restriction)see https://github.com/jpdriver/react-native-template/releases/tag/rn-0.85 for Release Notes
✌🏻