fix: Update CODEOWNERS for dependencies#726
Open
colinmurphy wants to merge 1 commit into
Open
Conversation
|
colinmurphy
changed the title
Specific CODEOWNERS rules for dependency files override the wildcard, so colinmurphy and josephfusco were excluded from approving those files. Also adds ready_for_review trigger to dependabot workflow so the bot re-approves if a PR is ever converted out of draft.
colinmurphy
force-pushed
the
fix/codeowner-dependency-reviewers
branch
from
14821d1 to
13a4b04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@colinmurphyand@josephfuscoto all dependency file CODEOWNERS rules (composer.json,composer.lock,package.json, etc.) so human approvals satisfy the requirement when the bot is unavailabledependabot-automationworkflow to trigger onready_for_reviewso the bot re-approves if a Dependabot PR is ever converted out of draftContext
Specific CODEOWNERS rules override the wildcard, meaning
@colinmurphyand@josephfuscowere not code owners for dependency files. This caused PR #714 to be stuck waiting onwpe-ie-deploy-botorwpengine/spcseven after a manual approval.Test plan