Skip to content

chore: bump select to 1.9#649

Merged
zombieJ merged 1 commit into
masterfrom
codex/bump-select-1-9
Jun 30, 2026
Merged

chore: bump select to 1.9#649
zombieJ merged 1 commit into
masterfrom
codex/bump-select-1-9

Conversation

@zombieJ

@zombieJ zombieJ commented Jun 30, 2026

Copy link
Copy Markdown
Member

Summary

  • bump @rc-component/cascader to 1.18.0
  • update @rc-component/select dependency range to ~1.9.0
  • align clear interaction tests with @rc-component/select@1.9

Test

  • ut run lint
  • ut run tsc
  • ut test

Summary by CodeRabbit

  • Chores
    • 更新了应用版本号,并同步升级了相关组件依赖。
  • Bug Fixes
    • 优化了清除操作的交互测试覆盖,确保单选和多选场景下的清除行为表现更稳定。

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cascader Ready Ready Preview, Comment Jun 30, 2026 9:38am

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.39%. Comparing base (b7492d2) to head (6c5d8d4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #649   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files          22       22           
  Lines         661      661           
  Branches      193      204   +11     
=======================================
  Hits          657      657           
  Misses          4        4           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit 6c5d8d4.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package version to 1.18.0 and bumps the @rc-component/select dependency to version ~1.9.0. Additionally, it updates the test suite in tests/selector.spec.tsx to trigger a click event instead of a mouseDown event when interacting with the clear button. There are no review comments, so no feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: de43e89f-686f-4a9f-8210-b971884d4bf4

📥 Commits

Reviewing files that changed from the base of the PR and between b7492d2 and 6c5d8d4.

📒 Files selected for processing (2)
  • package.json
  • tests/selector.spec.tsx

概览

将包版本升级至 1.18.0@rc-component/select 依赖从 ~1.8.0 升级至 ~1.9.0,并将三处 allowClear 测试中清除按钮的触发事件由 mouseDown 改为 click

版本升级与清除事件修复

层级 / 文件 摘要
版本与依赖更新
package.json
包版本从 1.17.0 升至 1.18.0@rc-component/select 依赖约束从 ~1.8.0 升至 ~1.9.0
allowClear 测试事件改为 click
tests/selector.spec.tsx
singleShould clear activeCellsmultiple 三个 allowClear 测试用例的清除按钮触发方式由 fireEvent.mouseDown 改为 fireEvent.click

估算代码审查难度

🎯 1 (Trivial) | ⏱️ ~3 minutes

可能相关的 PR

  • react-component/cascader#606:同样在 package.json 中升级了 @rc-component/select 依赖版本,与本次变更直接相关。
  • react-component/cascader#630:同样调整了 tests/selector.spec.tsx 中清除交互的触发方式,与本次 allowClear 测试改动一致。

小诗

🐇 版本跳一跳,1.18 来报到,
依赖升一升,select 焕新貌,
mouseDown 退休啦,click 来接班,
测试稳如山,兔子乐开怀! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确反映了将 select 升级到 1.9 的核心变更,且与本次依赖更新和测试调整相关。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/bump-select-1-9

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

tests/selector.spec.tsx

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​rc-component/​select@​1.9.19810010099100

View full report

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

✅ Preview is ready!

PR preview ✅ Ready ✅ Ready
🔗 Preview https://react-component-cascader-preview-pr-649.surge.sh
📝 Commit6c5d8d4
⏱️ Build time22.273s
📦 Size2.1 MB · 113 files
🪵 LogsView logs
📱 MobileScan to open preview on mobile

↩️ Previous: ⚡️ 6c5d8d4 · react-component-cascader-preview-pr-649.surge.sh (open ↗) · 2026-06-30 09:38:31 UTC

🤖 Powered by surge-preview

@zombieJ zombieJ merged commit ef09fc0 into master Jun 30, 2026
14 of 15 checks passed
@zombieJ zombieJ deleted the codex/bump-select-1-9 branch June 30, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant