fix: issue where zip action won't work for bun setup#25
Open
pramodjodhani wants to merge 1 commit into
Open
Conversation
Bun-only repos have no package-lock.json, which made setup-node's npm cache restore fail with "Dependencies lock file is not found."
pramodjodhani
changed the title
pramodjodhani
changed the title
d4mation
reviewed
Jul 6, 2026
Comment on lines
+101
to
+108
| - name: Check for npm lockfile | ||
| id: check-lockfile | ||
| run: | | ||
| if [ -f package-lock.json ] || [ -f npm-shrinkwrap.json ] || [ -f yarn.lock ]; then | ||
| echo "exists=true" >> $GITHUB_OUTPUT | ||
| else | ||
| echo "exists=false" >> $GITHUB_OUTPUT | ||
| fi |
There was a problem hiding this comment.
It could be worthwhile to add a short comment above this block explaining that it ensures actions/setup-node works as-expected in scenarios where a npm lockfile doesn't exist (such as when only bun is used).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bun-only repos have no package-lock.json, which made setup-node's npm cache fail with "Dependencies lock file is not found" error.
Added a check for package-lock.json file, if this file doesn't exist then we skip the cache during the
actions/setup-node@v4step.