Skip to content

fix: issue where zip action won't work for bun setup #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pramodjodhani merged 2 commits into from
Jul 6, 2026
+14 −1
Merged

fix: issue where zip action won't work for bun setup #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7deb19d
fix: only enable npm cache in setup-node when a lockfile exists
pramodjodhani Jul 6, 2026
18e15be
add comment explaining the reason for the check-lockfile step
pramodjodhani Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/workflows/zip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,24 @@ jobs:
echo "exists=false" >> $GITHUB_OUTPUT
fi

# ------------------------------------------------------------------------------
# Ensures actions/setup-node works as-expected in scenarios where a npm lockfile
# doesn't exist, such as when only bun is used.
# ------------------------------------------------------------------------------
- name: Check for npm lockfile
id: check-lockfile
run: |
if [ -f package-lock.json ] || [ -f npm-shrinkwrap.json ] || [ -f yarn.lock ]; then
echo "exists=true" >> $GITHUB_OUTPUT
else
echo "exists=false" >> $GITHUB_OUTPUT
fi
Comment thread
d4mation marked this conversation as resolved.

- uses: actions/setup-node@v4
if: steps.check-nvmrc.outputs.exists == 'true'
with:
node-version-file: '.nvmrc'
cache: 'npm'
cache: ${{ steps.check-lockfile.outputs.exists == 'true' && 'npm' || '' }}

- name: Set up authentication for NODE_AUTH_TOKEN if present
run: |
Expand Down